docs: document close-on-exec behavior in socket try_clone methods #151240
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that `try_clone()` sets the close-on-exec flag on duplicated sockets, addressing issue rust-lang#47946. On Unix, `F_DUPFD_CLOEXEC` is used to atomically duplicate the file descriptor with the close-on-exec flag set. On Windows, the duplicated socket is created without `HANDLE_FLAG_INHERIT`. This affects: - `TcpStream::try_clone()` - `TcpListener::try_clone()` - `UdpSocket::try_clone()` - `UnixStream::try_clone()` - `UnixListener::try_clone()` - `UnixDatagram::try_clone()`
rustbot
added
O-unix
Collaborator
|
|
Collaborator
|
Contributor
Author
Solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that
try_clone()sets the close-on-exec flag on duplicated sockets, addressing issue #47946.On Unix,
F_DUPFD_CLOEXECis used to atomically duplicate the file descriptor with the close-on-exec flag set. On Windows, the duplicated socket is created withoutHANDLE_FLAG_INHERIT.This affects:
TcpStream::try_clone()TcpListener::try_clone()UdpSocket::try_clone()UnixStream::try_clone()UnixListener::try_clone()UnixDatagram::try_clone()r? @joshtriplett