Skip to content

Updated workflow to support python 3.10#230

Merged
wRAR merged 8 commits into
scrapy:masterfrom
Nirzak:patch-1
Oct 12, 2021
Merged

Updated workflow to support python 3.10#230
wRAR merged 8 commits into
scrapy:masterfrom
Nirzak:patch-1

Conversation

@Nirzak
Copy link
Copy Markdown
Contributor

@Nirzak Nirzak commented Oct 9, 2021

Updated test workflow and added classifier to support python 3.10.

Copy link
Copy Markdown
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update checks.yml to use 3.10 instead of 3.9 where possible.

Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
@Nirzak
Copy link
Copy Markdown
Contributor Author

Nirzak commented Oct 9, 2021

Should I also update publish.yml?
And another thing. I think readthedocs supports python 3.9 now. https://docs.readthedocs.io/en/stable/config-file/v2.html I have seen both scrapy and parsel repositories are using python 3.8 for this. Should we update this?

@Gallaecio
Copy link
Copy Markdown
Member

Should I also update publish.yml?

Yes, please!

And another thing. I think readthedocs supports python 3.9 now. https://docs.readthedocs.io/en/stable/config-file/v2.html I have seen both scrapy and parsel repositories are using python 3.8 for this. Should we update this?

Yes, and I think they also support 3.10.

Nirzak added 3 commits October 9, 2021 17:06
Updated the python version of docs to keep it sync with readthedocs
Updated publish.yml to add support for python 3.10
@Nirzak
Copy link
Copy Markdown
Contributor Author

Nirzak commented Oct 9, 2021

Should I also update publish.yml?

Yes, please!

And another thing. I think readthedocs supports python 3.9 now. https://docs.readthedocs.io/en/stable/config-file/v2.html I have seen both scrapy and parsel repositories are using python 3.8 for this. Should we update this?

Yes, and I think they also support 3.10.

Yeah updated it. Please check now if any other changes are needed?

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2021

Codecov Report

Merging #230 (0fc2c2f) into master (fdba8af) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          290       290           
  Branches        50        50           
=========================================
  Hits           290       290           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdba8af...0fc2c2f. Read the comment docs.

@Gallaecio
Copy link
Copy Markdown
Member

Gallaecio commented Oct 9, 2021

Thank you. I think that’s it.

The only failing check is due to a new version of pylint which adds new checks. We should probably handle that separately, in a similar fashion to how it was handled in Scrapy (probably also pinning the pylint version to avoid similar issues in the future), so I think it is fine to merge this pull request as is, as soon as another maintainer also approves the changes.

@Nirzak
Copy link
Copy Markdown
Contributor Author

Nirzak commented Oct 9, 2021

Thank you. I think that’s it.

The only failing check is due to a new version of pylint which adds new checks. We should probably handle that separately, in a similar fashion to how it was handled in Scrapy (probably also pinning the pylint version to avoid similar issues in the future), so I think it is fine to merge this pull request as is, as soon as another maintainer also approves the changes.

Ok sir.

@wRAR wRAR merged commit 7a0f8e1 into scrapy:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants