Skip to content

chore(repo): add informational blocks to the design system#433

Merged
shellscape merged 6 commits into
mainfrom
charlie/issue-432-info-bubbles-design-system
Apr 22, 2026
Merged

chore(repo): add informational blocks to the design system#433
shellscape merged 6 commits into
mainfrom
charlie/issue-432-info-bubbles-design-system

Conversation

@charliecreates
Copy link
Copy Markdown
Contributor

Summary

  • add reusable informational bubble styles (warning, info, tip) to apps/web/src/public/design-system.html
  • define theme-aware CSS variables for bubble text, background, code tokens, and link accents in both light and dark previews
  • include base typography/layout rules so the preview reflects production-style informational blocks

Validation

  • inspected the generated diff to confirm scope is limited to apps/web/src/public/design-system.html

Resolves #432

@charliecreates charliecreates Bot mentioned this pull request Apr 21, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in the conventional commit (https://www.conventionalcommits.org/en/v1.0.0-beta.4/) format. e.g.

chore: add pr title workflow
```. Note that scopes should not contain spaces.

@shellscape
Copy link
Copy Markdown
Owner

@CharlieHelps

Link styles in all three bubble types in dark mode are incorrect. See http://localhost:5173/docs/quick-start and http://localhost:5173/docs/components/butan as references. Most notably, there is no underline, the font weight is wrong, and the colors are wrong.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in the conventional commit (https://www.conventionalcommits.org/en/v1.0.0-beta.4/) format. e.g.

chore: add pr title workflow
```. Note that scopes should not contain spaces.

@charliecreates
Copy link
Copy Markdown
Contributor Author

Implemented — I updated dark-mode link styling for all three informational bubble types (warning, info, tip) in apps/web/src/public/design-system.html.

Changes include:

  • restored link underline in dark mode
  • corrected link font weight
  • corrected per-bubble link/hover colors

Commit: c26d378

@shellscape
Copy link
Copy Markdown
Owner

@CharlieHelps

c26d378 should be reverted. Then the links styling should be fixed. Link styles in all three bubble types in dark mode are incorrect. See http://localhost:5173/docs/quick-start and http://localhost:5173/docs/components/butan as references.

  • Transition color is wrong
  • Links have underlines - this is incorrect
  • Links have a font weight of 600 - this is incorrect

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in the conventional commit (https://www.conventionalcommits.org/en/v1.0.0-beta.4/) format. e.g.

chore: add pr title workflow
```. Note that scopes should not contain spaces.

@charliecreates
Copy link
Copy Markdown
Contributor Author

Completed ✅

  • Reverted c26d378 via 67dce3f.
  • Fixed dark-mode informational bubble link styles via 4ee712a.
  • Dark-mode fixes cover warning/info/tip bubbles and address transition color, underline removal, and incorrect font weight.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in the conventional commit (https://www.conventionalcommits.org/en/v1.0.0-beta.4/) format. e.g.

chore: add pr title workflow
```. Note that scopes should not contain spaces.

@shellscape shellscape changed the title Add informational bubbles to web design system preview chore(repo): add informational blocks to the design system Apr 22, 2026
@shellscape shellscape merged commit 8ec0e16 into main Apr 22, 2026
19 of 20 checks passed
@shellscape shellscape deleted the charlie/issue-432-info-bubbles-design-system branch April 22, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

charlie: design system

2 participants