Conversation
Collaborator
|
Thanks!! This is great. The limitation about functions will probably cause trouble for people, but this is much better than nothing. We can figure out later how to support functions (potentially supported by later releases of pytorch). I am on travel right now and will be for the next 11 days and won't have a chance to carefully review this until I am back. But I'll look it over to get it merged as soon as I can. |
Collaborator
|
Thanks again! Merging this now :) ...if they re-expose saved_tensors then we can look at that then. I expect there will be some corner case stuff we run into, but that can be fixed when we find it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is the second part of a solution to #191. I would appreciate any feedback!
Here are two notes about this pull request:
In PyTorch, this graph is generated using Function objects; these used to have a
saved_tensorsattribute, which made the input tensors accessible. However, as more and more functions are being written in C++, this is no longer the case. If these saved tensors are exposed once again, it would make sense to use them, especially since function objects can handle backward hooks (which allow the gradients to be manipulated).What is implemented is a backpropagation along the Module objects, which are a little coarser. As an example, the following network works with the Deep Explainer, because all operations are captured in a module object:
but the following doesn't:
because the relu activations, the maxpooling and the dropout happen using functions, not modules. I understand that this limits the functionality somewhat, and did spend some time trying to use the
Functions instead.tuple(model, layer) is passed, then the inputs of that interim layer will be explained.