Collapsible Header#191
Merged
Merged
Conversation
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Contributor
|
👍 but after
it's kind-of starts to feel a bit repetitive 😆 but still, in my experience, having a screenshot for UI changes speeds up the review. |
Contributor
Author
|
it looks exactly as on screenshot in the issue |
dpordomingo
approved these changes
Mar 2, 2018
dpordomingo
left a comment
dpordomingo
left a comment
Contributor
There was a problem hiding this comment.
LGTM,
many thanks @smacker for removing that much of duplicated code 💯 👍
Contributor
|
@bzz I updated the issue desc with two screenshots comparing the two states, so then the PR can be easily reviewed |
Contributor
Ideally it would slide down from off-canvas :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #54
Normal state:
When you hover the header, the other header appears above the initial one:
