Skip to content

Avoid external dependencies#231

Merged
dpordomingo merged 1 commit into
src-d:release/v0.0.8from
dpordomingo:use-internal-ci
Apr 4, 2018
Merged

Avoid external dependencies#231
dpordomingo merged 1 commit into
src-d:release/v0.0.8from
dpordomingo:use-internal-ci

Conversation

@dpordomingo

@dpordomingo dpordomingo commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

Depends on #230 src-d/ci#58 src-d/ci#60 src-d/ci#61

Use src-d/ci:v1 to avoid external dependencies

@dpordomingo dpordomingo requested review from carlosms and smacker March 26, 2018 09:42
@dpordomingo

Copy link
Copy Markdown
Contributor Author

Travis fails because #230 has not been yet merged

@dpordomingo dpordomingo self-assigned this Mar 26, 2018
@smacker

smacker commented Mar 27, 2018

Copy link
Copy Markdown
Contributor

CI is failing on make build-app

@dpordomingo

Copy link
Copy Markdown
Contributor Author

@smacker ptal #231 (comment)

@smacker

smacker commented Mar 27, 2018

Copy link
Copy Markdown
Contributor

aaah. I got it! You can't create this PR on top of #230 because that one for another branch.

@dpordomingo

Copy link
Copy Markdown
Contributor Author

@smacker #230 was already merged so this PR build already passed; could you ptal again ;)
thanks!

@smacker smacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but I still think it's not a good idea to maintain CI fork inside code-annotation project.

@smacker

smacker commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

@bzz maybe you also want to take a look

@bzz

bzz commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

approved, but I still think it's not a good idea to maintain CI fork inside code-annotation project.

totally see @smacker point and agree

Sorry, I must have missed that, but what was the original reason for having https://github.com/src-d/code-annotation/tree/ci ?

@dpordomingo

dpordomingo commented Apr 3, 2018

Copy link
Copy Markdown
Contributor Author

@bzz since we cannot use srcd/ci:v1, I found the following alternatives:

  • (a) keep relying on carlosms/ci:add-drone-v1, dependency outside the company; wich can be deleted without our control and which requires extra overhead for maintenance,
  • (b) push this new branch to a new one into srcd/ci, for example, srcd/ci:v1.1-candidate; I'm not sure if we should push our stuff there, and use it instead of srcd/ci:v1
  • (c) try to merge the new features into srcd/ci:v1Set VERSION for Drone CI ci#58 Replace '/' char from version ci#60 waiting since Feb 28th
  • (d) create our own srcd/apps-ci → please, no,
  • (e) keep this new branch inside this repo

I choose (e) until (c) is unblocked, what would you purpose?

@dpordomingo

Copy link
Copy Markdown
Contributor Author

internal branch (e) is no longer needed since src-d/ci#58 src-d/ci#60 src-d/ci#61 PRs were just merged

@dpordomingo dpordomingo merged commit 3ad9a2f into src-d:release/v0.0.8 Apr 4, 2018
@dpordomingo dpordomingo deleted the use-internal-ci branch April 4, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants