Skip to content

Conversation

@jesseleite
Copy link
Contributor

@jesseleite jesseleite commented Nov 5, 2024

It was reported that there was some lingering issues re-ordering CP nav items, partly due to storing preferences in JSON in SQL, but also partly due to some missing implementation.

Todo

  • Test and fix issues at NavTransformer level
    • The transformer is what converts the Vue payload to YAML/JSON when storing preferences
  • Test and fix issues at NavPreferencesNormalizer level
    • The normalizer is what run when reading YAML/JSON
    • This is important for re-ordering, because we support the old reorder: true boolean for backwards compatibility
  • Test and fix issues at NavBuilder level
    • This is where the nav is actually built after reading YAML/JSON and normalizing
    • First the core nav is built, the normalized preferences are applied on top
  • Test with TV2

@jasonvarga jasonvarga marked this pull request as ready for review October 15, 2025 20:56
@jasonvarga jasonvarga merged commit 72f2075 into 5.x Oct 15, 2025
25 checks passed
@jasonvarga jasonvarga deleted the fix/cp-nav-custom-section-reordering branch October 15, 2025 21:12
duncanmcclean added a commit that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants