Text Selection refactoring of Ralph - continuation of PR #238 - fixing final tests

[svanteschubert]

I have reviewed and continued Ralph's PR #238

The Fix in the Nutshell:
Realized that two navigators where working on the same DOC and one was changing the DOC, but the other had a cached selection, which was not updated as the prior STATIC SelectionManager should now be moved to the OdfDocument instance to be able to dirty flag

According to GitHub docu - and from my understanding of it - I can only contribute to a PR, by creating a new one:
https://docs.github.com/de/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

This is what I did today:

1. update my PR branch
2. Complete build of ODF Toolkit successfull on Windows 10 -> but a dozen files with Indent Normalization
3. These files changed by "Indent Normalization" committed locally to remove noise
4. The two ignored Tests activated in TextSelectionTest(@ignore deleted) & all test output files named differently in relation to their test method
5. does hang/loop in this TextSelectionTest in complete build.. - pasteAtEndOf causes loop
6. Enhance readablity in Tests - Making TextSelection and TextNavigation variables mnemonic, e.g. search4XY and selection4XY
7. Enhance robustness in Tests -> Exchanging global TextSelection & TextNavigation variables with local ones!
8. Fixed loop see above.

[rsoika]

looks all good to me

[rsoika]

looks all good to me

[rsoika]

yes - works now perfect!

[rsoika]

Ok - I understand and yes this is a perfect solution to get away form the singleton.
But what do think about adding a method resetSelections
this can be necessary if user did first search and modify the doc and than - before he saves the document - what to modify the result again - now she should have the chance to reset the current selections ?

[svanteschubert]

Sure, the SelectionManager could offer such a functionality. Let me update!

[svanteschubert]

I called the method unregisterAll() as there was already a method called:
public void unregisterItem(Selection item)

[rsoika]

looks good to me