[utxo by address] - Filter implemented#18
Merged
Conversation
scarmuega
reviewed
Jun 1, 2022
| tx_idx: usize, | ||
| output: &mut super::OutputPort, | ||
| ) -> Result<(), gasket::error::Error> { | ||
| if self.config.filter.is_some() { |
Member
There was a problem hiding this comment.
I think you should explore Rust's if let syntax, it will probably result in something more compact (won't change logic, just more ergonomic).
Contributor
Author
There was a problem hiding this comment.
Implemented. Better like that? :)
scarmuega
reviewed
Jun 1, 2022
| if self.config.filter.is_some() { | ||
| match self.config.filter.as_ref().unwrap().binary_search(&address.to_string()) { | ||
| Ok(_) => { | ||
| log::info!("Address '{}' added with UTXO data", address); |
Member
There was a problem hiding this comment.
Using info log level seems a little excessive. I would use debug level, if any.
Ideally, we should promote metrics / counters rather than logs for these high-frequency observations. Not required for this PR, but it might be a nice addition for a follow up.
Contributor
Author
There was a problem hiding this comment.
Indeed those logs are too much.
I've created an issue out of your metrics proposition
scarmuega
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR to an open source project!
I spent some time to understand the whole project flow. Please keep in mind I am relatively new to Rust.
So the address filter for the UtxoByAddress reducer has been implemented (Issue #14). How to use it is showed in the exemple .toml
The filter is optional.
I've decided to implement the functionality directly into the "send_set_add" instead of implementing it twice separately in the reduce_byron/alonzo_tx.
I went with the "binary_search" as it seems to be good fast option (https://stackoverflow.com/questions/67525751/what-is-the-fastest-way-to-check-if-something-exist-in-a-vector-in-rust).
I hope it helps! That ain't much but consider it as my entry implication to the project. Feedbacks are ofc more than welcome ;)