fix: increment TxCountByAddress once per tx#72
Merged
Conversation
Contributor
Author
|
It also tracks invalid transactions. I guess there's not really a definition on how you count invalid transactions. If we want to be extra-precise maybe for invalid transactions we check the collateral inputs and collateral outputs instead of the standard inputs and outputs. |
scarmuega
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #71
TxCountByAddress now increments the tx counter once per tx for every address in the transaction inputs and outputs by maintaining a set of already-seen addresses while processing each transaction. For each address, if it is not included in the seen-addresses set then increment the counter and insert the address into the set.
I wasn't sure if I should build the set then iterate over each address to do the send, or to maybe build the prefix before trying the insert into the set to avoid the clone, but I think the current implementation was the best option.