Skip to content

*sum: Fix locales fetching from checksum_common after installation#10575

Merged
RenjiSann merged 1 commit into
uutils:mainfrom
RenjiSann:fix-sum-locales
Feb 2, 2026
Merged

*sum: Fix locales fetching from checksum_common after installation#10575
RenjiSann merged 1 commit into
uutils:mainfrom
RenjiSann:fix-sum-locales

Conversation

@RenjiSann

@RenjiSann RenjiSann commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Fixes the issue raised in #10142 (comment) and #10549

Basically, this change does 3 things:

  • Embeds checksum_common en_US locales in uucore at build time if necessary.
  • Make init_localization look for checksum_common locales.
  • Install extra locales for checksum_common when running make install.

cc @oech3

@RenjiSann RenjiSann requested a review from sylvestre January 30, 2026 11:04
@oech3

oech3 commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

We have sum command, but is .ends_with("sum") OK if we don't use ck-* translations?

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@RenjiSann

Copy link
Copy Markdown
Collaborator Author

We have sum command, but is .ends_with("sum") OK if we don't use ck-* translations?

Good catch. It's not problematic: we will just include the common locales for it even though it doesn't need it.
Actually, I never looked at sum, maybe we can port it to the common implementation as well

@oech3

oech3 commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Does release/debug profile specific regression test works correctly?

@RenjiSann

Copy link
Copy Markdown
Collaborator Author

Does release/debug profile specific regression test works correctly?

I'm not sure it is actually possible to test the release installation.

@RenjiSann RenjiSann merged commit 3bab3a8 into uutils:main Feb 2, 2026
131 of 180 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants