Skip to content

mv, cp: add support for --update=none,all,older#4796

Merged
cakebaker merged 26 commits into
uutils:mainfrom
shinhs0506:mv-cp-update
May 3, 2023
Merged

mv, cp: add support for --update=none,all,older#4796
cakebaker merged 26 commits into
uutils:mainfrom
shinhs0506:mv-cp-update

Conversation

@shinhs0506

Copy link
Copy Markdown
Contributor

#4627 cover mv/update
test still failing because of diff in err messages

@uutils uutils deleted a comment from github-actions Bot Apr 27, 2023
@cakebaker cakebaker changed the title Mv cp update mv, cp: add support for --update=none Apr 28, 2023
Comment thread src/uu/cp/src/cp.rs Outdated
Comment thread src/uu/mv/src/mv.rs Outdated
Comment thread src/uucore/src/lib/mods/update_control.rs Outdated
@sylvestre

Copy link
Copy Markdown
Contributor

i know it is the draft but don't forget the tests please :)

@shinhs0506 shinhs0506 changed the title mv, cp: add support for --update=none mv, cp: add support for --update=none,all,older May 1, 2023
@github-actions

github-actions Bot commented May 1, 2023

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!

Comment thread src/uu/cp/cp.md Outdated
Comment thread src/uu/cp/cp.md Outdated
Comment thread src/uu/cp/cp.md Outdated
Comment thread src/uu/mv/mv.md
Comment thread tests/by-util/test_cp.rs Outdated
Comment thread src/uucore/src/lib/mods/update_control.rs
@github-actions

github-actions Bot commented May 1, 2023

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!
Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@github-actions

github-actions Bot commented May 2, 2023

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!

@shinhs0506 shinhs0506 marked this pull request as ready for review May 2, 2023 02:18
Comment thread tests/by-util/test_mv.rs Outdated
Comment thread tests/by-util/test_cp.rs Outdated
Comment thread tests/by-util/test_cp.rs Outdated
Comment thread tests/by-util/test_cp.rs Outdated
Comment thread tests/by-util/test_cp.rs
Comment thread src/uucore/src/lib/mods/update_control.rs Outdated
Comment thread src/uucore/src/lib/mods/update_control.rs Outdated
Comment thread src/uucore/src/lib/mods/update_control.rs Outdated
Comment thread src/uucore/src/lib/mods/update_control.rs Outdated

@cakebaker cakebaker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work :)

@github-actions

github-actions Bot commented May 2, 2023

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!

@github-actions

github-actions Bot commented May 3, 2023

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@cakebaker cakebaker merged commit a97199f into uutils:main May 3, 2023
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants