basenc: implement --base58 encoding option#8751
Merged
Merged
Conversation
AnarchistHoneybun
force-pushed
the
feat/basenc-base58
branch
from
d536436 to
54c12e0
Compare
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #8751 will not alter performanceComparing Summary
Footnotes
|
Contributor
Author
|
@cakebaker could you review these changes, I can't figure out how to fix the failing CI, like what exactly is it failing for? |
Contributor
|
The spell error is easy to fix. Just ignore it on the top of the file. |
Add support for Base58 encoding to basenc as per GNU coreutils 9.8. Base58 uses the alphabet '123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz' which excludes visually ambiguous characters (0, O, I, l). Resolves issue uutils#8744.
sylvestre
force-pushed
the
feat/basenc-base58
branch
from
54c12e0 to
1016664
Compare
|
GNU testsuite comparison: |
Contributor
|
please fix the rest of the errors :) |
Contributor
Author
Yes sorry been a little busy with class work, I'll have it done today |
Fix explicit iteration clippy warnings. Add Base58 alphabet to spell-checker ignore list to resolve cspell errors.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Base58 encoding to basenc for consistency with GNU coreutils 9.8. Base58 uses the alphabet '123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz' which excludes visually ambiguous characters (0, O, I, l).
Resolves #8744.