Add comprehensive readonly file regression tests for cp#9045
Merged
cakebaker merged 3 commits intoDec 10, 2025
Conversation
Contributor
|
please remove the trivial comments :) |
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
add-cp-readonly-regression-tests
branch
from
78e2aa7 to
b8d7d4a
Compare
CodSpeed Performance ReportMerging #9045 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
cakebaker
reviewed
Oct 28, 2025
naoNao89
force-pushed
the
add-cp-readonly-regression-tests
branch
4 times, most recently
from
5fddc7f to
a1fb012
Compare
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
add-cp-readonly-regression-tests
branch
2 times, most recently
from
9a80703 to
112f646
Compare
|
GNU testsuite comparison: |
- Add 10 new test functions covering readonly destination behavior - Tests cover basic readonly copying, flag combinations, and edge cases - Include macOS-specific clonefile behavior tests - Ensure readonly file protection from PR uutils#5261 cannot regress - Tests provide evidence for closing issue uutils#5349
- Reduce file I/O overhead by batching file operations - Consolidate setup operations to minimize system calls - Improve test execution time from 0.44s to 0.27s (38% improvement) - Maintain comprehensive test coverage for readonly file behavior
- Remove test_cp_readonly_dest_regression (duplicate of test_cp_dest_no_permissions) - Remove test_cp_readonly_dest_with_force (duplicate of test_cp_arg_force) - Remove test_cp_readonly_dest_with_remove_destination (duplicate of test_cp_arg_remove_destination) - Remove test_cp_macos_clonefile_readonly (duplicate of test_cp_existing_target) - Remove test_cp_normal_copy_still_works (duplicate of test_cp_existing_target) - Remove trivial performance comments from readonly tests - Keep existing proven tests per maintainer preferences - Keep unique readonly tests that provide additional coverage
cakebaker
force-pushed
the
add-cp-readonly-regression-tests
branch
from
112f646 to
271621e
Compare
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #5349
The tests ensure the readonly file behavior from PR #5261 cannot regress in future development.