Add --debug flag to cksum#9088

naoNao89 · 2025-10-30T04:56:04Z

This PR implements the --debug flag for cksum, split from the original PR #8948.

What's included:

--debug CLI argument with help text
Localization for English and French
Tests covering single file, multiple files, and algorithm combinations

codspeed-hq · 2025-10-30T05:08:50Z

CodSpeed Performance Report

Merging #9088 will not alter performance

_{Comparing naoNao89:fix-cksum-debug-flag (43f3eb3) with main (b2d1117)}

Summary

✅ 126 untouched
⏩ 6 skipped¹

6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-10-30T05:16:50Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

cakebaker

Can you please add a hint to the help text that the debug functionality is not yet implemented? To make it visible to the user that it is a no-op. Otherwise the PR looks good.

naoNao89 · 2025-10-30T10:37:13Z

@cakebaker Updated! ✅

Added the clarification to the help text as requested:

English:

--debug    indicate which implementation used (not yet implemented)

French:

--debug    indiquer quelle implémentation est utilisée (pas encore implémenté)

This follows the same pattern used by other utilities in the codebase (cp, mkdir, split) for indicating unimplemented features.

The test still passes:

test test_cksum::test_debug_flag ... ok

github-actions · 2025-10-30T11:01:32Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

sylvestre · 2025-10-30T11:03:39Z

Why not implementing it?

github-actions · 2025-10-30T15:42:01Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions · 2025-11-01T07:50:28Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-01T13:13:37Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-01T14:08:10Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-01T15:25:39Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-01T18:41:25Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-01T20:00:23Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-02T04:17:20Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-02T06:47:43Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-02T07:28:01Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-02T10:39:05Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-24T23:02:25Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-25T02:53:42Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-25T18:12:53Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-25T23:12:49Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-25T23:49:09Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

RenjiSann · 2025-11-26T11:30:49Z

Thanks !

cakebaker reviewed Oct 30, 2025

View reviewed changes

naoNao89 marked this pull request as draft October 30, 2025 11:25

naoNao89 marked this pull request as ready for review October 30, 2025 18:09

cakebaker reviewed Oct 31, 2025

View reviewed changes

Comment thread tests/by-util/test_cksum.rs

sylvestre mentioned this pull request Nov 1, 2025

dd: optimize O_DIRECT buffer alignment to reduce syscall overhead #9104

Open

2 tasks

naoNao89 force-pushed the fix-cksum-debug-flag branch from 0d611e3 to 7fd6bd7 Compare November 1, 2025 12:19

naoNao89 force-pushed the fix-cksum-debug-flag branch 3 times, most recently from e99e61e to c4276f6 Compare November 1, 2025 13:46

naoNao89 mentioned this pull request Nov 1, 2025

bench: remove 'sort_random_strings' #9030

Merged

RenjiSann reviewed Nov 24, 2025

View reviewed changes

Comment thread Cargo.toml Outdated

naoNao89 force-pushed the fix-cksum-debug-flag branch 3 times, most recently from c3ba054 to 82cb1e1 Compare November 24, 2025 22:46

naoNao89 requested a review from RenjiSann November 24, 2025 23:36

RenjiSann reviewed Nov 24, 2025

View reviewed changes

Comment thread tests/by-util/test_cksum.rs Outdated

RenjiSann reviewed Nov 24, 2025

View reviewed changes

Comment thread tests/fixtures/cksum/base64/crc32b_single_file.expected

RenjiSann reviewed Nov 24, 2025

View reviewed changes

Comment thread src/uu/cksum/src/cksum.rs

naoNao89 force-pushed the fix-cksum-debug-flag branch 2 times, most recently from f94e999 to 5ba81e1 Compare November 25, 2025 02:37

naoNao89 requested a review from RenjiSann November 25, 2025 04:48

RenjiSann reviewed Nov 25, 2025

View reviewed changes

Comment thread tests/by-util/test_cksum.rs Outdated

naoNao89 force-pushed the fix-cksum-debug-flag branch from 5ba81e1 to 19ea339 Compare November 25, 2025 17:57

feat(cksum): improve debug output for single file operations

77d2dd3

naoNao89 force-pushed the fix-cksum-debug-flag branch from 19ea339 to 77d2dd3 Compare November 25, 2025 22:56

Merge branch 'main' into fix-cksum-debug-flag

43f3eb3

RenjiSann approved these changes Nov 26, 2025

View reviewed changes

RenjiSann merged commit d655eed into uutils:main Nov 26, 2025
128 checks passed

naoNao89 deleted the fix-cksum-debug-flag branch November 26, 2025 11:58

moonfruit mentioned this pull request Dec 15, 2025

uutils-selected 0.5.0 moonfruit/homebrew-tap#387

Closed

Uh oh!

Conversation

naoNao89 commented Oct 30, 2025

Uh oh!

codspeed-hq Bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9088 will not alter performance

Summary

Footnotes

Uh oh!

github-actions Bot commented Oct 30, 2025

Uh oh!

cakebaker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naoNao89 commented Oct 30, 2025

Uh oh!

github-actions Bot commented Oct 30, 2025

Uh oh!

sylvestre commented Oct 30, 2025

Uh oh!

github-actions Bot commented Oct 30, 2025

Uh oh!

Uh oh!

github-actions Bot commented Nov 1, 2025

Uh oh!

github-actions Bot commented Nov 1, 2025

Uh oh!

github-actions Bot commented Nov 1, 2025

Uh oh!

github-actions Bot commented Nov 1, 2025

Uh oh!

github-actions Bot commented Nov 1, 2025

Uh oh!

github-actions Bot commented Nov 1, 2025

Uh oh!

github-actions Bot commented Nov 2, 2025

Uh oh!

github-actions Bot commented Nov 2, 2025

Uh oh!

github-actions Bot commented Nov 2, 2025

Uh oh!

github-actions Bot commented Nov 2, 2025

Uh oh!

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

Uh oh!

RenjiSann commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codspeed-hq Bot commented Oct 30, 2025 •

edited

Loading

cakebaker left a comment •

edited

Loading