Adding integration tests for the braced variable parsing in env#9459
Merged
Conversation
|
GNU testsuite comparison: |
Contributor
|
codecov/project — 88.27% (+0.08%) compared to 9f1922b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been going through the code coverage site to see which areas are still missing tests and saw that the majority of the variable parsing in the env bin did not have integration tests. This should be expanded on even further especially for the default value parsing because this feature does not exist in the GNU implementation and the current implementation does not match the BSD spec either.