Skip to content

fix: load Image/IFrame sources when disabled (CP: 24.10)#24365

Merged
caalador merged 1 commit into
24.10from
cherry/cherrypick-24346-to-24.10
May 19, 2026
Merged

fix: load Image/IFrame sources when disabled (CP: 24.10)#24365
caalador merged 1 commit into
24.10from
cherry/cherrypick-24346-to-24.10

Conversation

@mcollovati
Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #24346 to branch 24.10.


When an Image or IFrame backed by a DownloadHandler lives inside a disabled component, the browser receives a 403 and the resource never loads.

Image.setSrc(DownloadHandler) and IFrame.setSrc(DownloadHandler) now allow the resource to be served regardless of the owner's enabled state, since these sources are fetched passively as part of rendering rather than as a user action.

Fixes #22772

When an `Image` or `IFrame` backed by a `DownloadHandler` lives inside a
disabled component, the browser receives a 403 and the resource never
loads.

`Image.setSrc(DownloadHandler)` and `IFrame.setSrc(DownloadHandler)` now
allow the resource to be served regardless of the owner's enabled state,
since these sources are fetched passively as part of rendering rather
than as a user action.

Fixes #22772
@mcollovati mcollovati marked this pull request as ready for review May 18, 2026 14:16
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Test Results

1 291 files  + 2  1 291 suites  +2   1h 16m 39s ⏱️ +8s
8 911 tests +10  8 849 ✅ +10  62 💤 ±0  0 ❌ ±0 
9 296 runs   -  3  9 228 ✅  -  1  68 💤  - 2  0 ❌ ±0 

Results for commit edcb237. ± Comparison against base commit fd2adf9.

@caalador caalador merged commit bce9f25 into 24.10 May 19, 2026
28 checks passed
@caalador caalador deleted the cherry/cherrypick-24346-to-24.10 branch May 19, 2026 04:11
caalador pushed a commit that referenced this pull request May 19, 2026
…: 24.9) (#24370)

When an Image or IFrame backed by a DownloadHandler lives inside a disabled component, the browser receives a 403 and the resource never loads.

Image.setSrc(DownloadHandler) and IFrame.setSrc(DownloadHandler) now allow the resource to be served regardless of the owner's enabled state, since these sources are fetched passively as part of rendering rather than as a user action.

Fixes #22772
@vaadin-bot
Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.10.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants