checker: disallow constant modification on unsafe {} (#23588)

felipensp · web-flow · commit 15e3f6258d1b · 2025-01-28T12:55:45.000+03:00
diff --git a/vlib/v/checker/checker.v b/vlib/v/checker/checker.v
@@ -921,7 +921,7 @@ fn (mut c Checker) fail_if_immutable(mut expr ast.Expr) (string, token.Pos) {
 					}
 				}
 			} else if expr.obj is ast.ConstField && expr.name in c.const_names {
-				if !c.inside_unsafe && !c.pref.translated {
+				if !c.pref.translated {
 					// TODO: fix this in c2v, do not allow modification of all consts
 					// in translated code
 					c.error('cannot modify constant `${expr.name}`', expr.pos)

Original file line number	Diff line number	Diff line change
`@@ -921,7 +921,7 @@ fn (mut c Checker) fail_if_immutable(mut expr ast.Expr) (string, token.Pos) {`
`921`	`921`	`}`
`922`	`922`	`}`
`923`	`923`	`} else if expr.obj is ast.ConstField && expr.name in c.const_names {`
`924`		`- if !c.inside_unsafe && !c.pref.translated {`
	`924`	`+ if !c.pref.translated {`
`925`	`925`	`// TODO: fix this in c2v, do not allow modification of all consts`
`926`	`926`	`// in translated code`
`927`	`927`	c.error('cannot modify constant `${expr.name}`', expr.pos)