math.big: refactor add_digit_array() (#25138)

tankf33der · web-flow · commit 4c4028a84bc3 · 2025-08-20T02:19:18.000+03:00
diff --git a/vlib/math/big/array_ops.v b/vlib/math/big/array_ops.v
@@ -34,11 +34,15 @@ fn add_digit_array(operand_a []u64, operand_b []u64, mut sum []u64) {
 		for index in 0 .. operand_b.len {
 			sum[index] = operand_b[index]
 		}
+		shrink_tail_zeros(mut sum)
+		return
 	}
 	if operand_b.len == 0 {
 		for index in 0 .. operand_a.len {
 			sum[index] = operand_a[index]
 		}
+		shrink_tail_zeros(mut sum)
+		return
 	}
 
 	// First pass intersects with both operands
@@ -62,11 +66,8 @@ fn add_digit_array(operand_a []u64, operand_b []u64, mut sum []u64) {
 		carry = u64(partial >> digit_bits)
 	}
 
-	if carry == 0 {
-		sum.delete_last()
-	} else {
-		sum[larger_limit] = carry
-	}
+	sum[larger_limit] = carry
+	shrink_tail_zeros(mut sum)
 }
 
 // Subtracts operand_b from operand_a and stores the difference in storage.

Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,15 @@ fn add_digit_array(operand_a []u64, operand_b []u64, mut sum []u64) {`
`34`	`34`	`for index in 0 .. operand_b.len {`
`35`	`35`	`sum[index] = operand_b[index]`
`36`	`36`	`}`
	`37`	`+ shrink_tail_zeros(mut sum)`
	`38`	`+ return`
`37`	`39`	`}`
`38`	`40`	`if operand_b.len == 0 {`
`39`	`41`	`for index in 0 .. operand_a.len {`
`40`	`42`	`sum[index] = operand_a[index]`
`41`	`43`	`}`
	`44`	`+ shrink_tail_zeros(mut sum)`
	`45`	`+ return`
`42`	`46`	`}`
`43`	`47`
`44`	`48`	`// First pass intersects with both operands`
`@@ -62,11 +66,8 @@ fn add_digit_array(operand_a []u64, operand_b []u64, mut sum []u64) {`
`62`	`66`	`carry = u64(partial >> digit_bits)`
`63`	`67`	`}`
`64`	`68`
`65`		`- if carry == 0 {`
`66`		`- sum.delete_last()`
`67`		`- } else {`
`68`		`- sum[larger_limit] = carry`
`69`		`- }`
	`69`	`+ sum[larger_limit] = carry`
	`70`	`+ shrink_tail_zeros(mut sum)`
`70`	`71`	`}`
`71`	`72`
`72`	`73`	`// Subtracts operand_b from operand_a and stores the difference in storage.`