crypto.rc4: change the return type of new_cipher to be !&Cipher (#24113)

einar-hjortdal · web-flow · commit 5c8fd1562ec8 · 2025-04-03T16:26:11.000+03:00
diff --git a/vlib/crypto/rc4/rc4.v b/vlib/crypto/rc4/rc4.v
@@ -31,11 +31,11 @@ pub fn (mut c Cipher) free() {
 
 // new_cipher creates and returns a new Cipher. The key argument should be the
 // RC4 key, at least 1 byte and at most 256 bytes.
-pub fn new_cipher(key []u8) !Cipher {
+pub fn new_cipher(key []u8) !&Cipher {
 	if key.len < 1 || key.len > 256 {
 		return error('crypto.rc4: invalid key size ' + key.len.str())
 	}
-	mut c := Cipher{
+	mut c := &Cipher{
 		s: []u32{len: (256)}
 	}
 	for i in 0 .. 256 {

Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,11 @@ pub fn (mut c Cipher) free() {`
`31`	`31`
`32`	`32`	`// new_cipher creates and returns a new Cipher. The key argument should be the`
`33`	`33`	`// RC4 key, at least 1 byte and at most 256 bytes.`
`34`		`-pub fn new_cipher(key []u8) !Cipher {`
	`34`	`+pub fn new_cipher(key []u8) !&Cipher {`
`35`	`35`	`if key.len < 1 \|\| key.len > 256 {`
`36`	`36`	`return error('crypto.rc4: invalid key size ' + key.len.str())`
`37`	`37`	`}`
`38`		`- mut c := Cipher{`
	`38`	`+ mut c := &Cipher{`
`39`	`39`	`s: []u32{len: (256)}`
`40`	`40`	`}`
`41`	`41`	`for i in 0 .. 256 {`