parser,checker: vls skip unrelated files (#25531)

Author: kbkpbot

vlib/v/checker/autocomplete.v

@@ -284,7 +284,7 @@ fn (c &Checker) vls_gen_type_details(mut details []Detail, sym ast.TypeSymbol) {
 		method_ret_type := c.table.sym(method.return_type)
 		details << Detail{
 			kind:   .method
-			label:  c.build_fn_summary(method)
+			label:  method.name
 			detail: method_ret_type.name
 		}
 	}

vlib/v/checker/checker.v

@@ -354,6 +354,10 @@ pub fn (mut c Checker) check_files(ast_files []&ast.File) {
 		mut files_from_main_module := []&ast.File{}
 		for i in 0 .. ast_files.len {
 			mut file := ast_files[i]
+			if c.pref.is_vls && file.path != c.pref.path {
+				// in `vls` mode, only check the user file
+				continue
+			}
 			c.timers.start('checker_check ${file.path}')
 			c.check(mut file)
 			if file.mod.name == 'no_main' {

vlib/v/parser/fn.v

@@ -681,7 +681,11 @@ run them via `v file.v` instead',
 		p.inside_fn = true
 		p.inside_unsafe_fn = is_unsafe
 		p.cur_fn_scope = p.scope
-		stmts = p.parse_block_no_scope(true)
+		if p.is_vls_skip_file {
+			p.skip_scope()
+		} else {
+			stmts = p.parse_block_no_scope(true)
+		}
 		p.cur_fn_scope = last_fn_scope
 		p.inside_unsafe_fn = false
 		p.inside_fn = false

vlib/v/parser/parser.v

@@ -116,6 +116,7 @@ mut:
 	generic_type_level       int  // to avoid infinite recursion segfaults due to compiler bugs in ensure_type_exists
 	main_already_defined     bool // TODO move to checker
 	is_vls                   bool
+	is_vls_skip_file         bool // in `vls` mode, skip parse and check for unrelated files, such as `vlib`
 	inside_import_section    bool
 	cur_comments             []ast.Comment // comments between other stmts
 pub mut:
@@ -177,16 +178,17 @@ pub fn parse_text(text string, path string, mut table ast.Table, comments_mode s
 		eprintln('> ${@MOD}.${@FN} comments_mode: ${comments_mode:-20} | path: ${path:-20} | text: ${text}')
 	}
 	mut p := Parser{
-		scanner:  scanner.new_scanner(text, comments_mode, pref_)
-		table:    table
-		pref:     pref_
-		is_vls:   pref_.is_vls
-		scope:    &ast.Scope{
+		scanner:          scanner.new_scanner(text, comments_mode, pref_)
+		table:            table
+		pref:             pref_
+		is_vls:           pref_.is_vls
+		is_vls_skip_file: pref_.is_vls && path != pref_.path
+		scope:            &ast.Scope{
 			start_pos: 0
 			parent:    table.global_scope
 		}
-		errors:   []errors.Error{}
-		warnings: []errors.Warning{}
+		errors:           []errors.Error{}
+		warnings:         []errors.Warning{}
 	}
 	p.set_path(path)
 	mut res := p.parse()
@@ -269,14 +271,15 @@ pub fn parse_file(path string, mut table ast.Table, comments_mode scanner.Commen
 		pref:    pref_
 		// Only set vls mode if it's the file the user requested via `v -vls-mode file.v`
 		// Otherwise we'd be parsing entire stdlib in vls mode
-		is_vls:   pref_.is_vls && path == pref_.path
-		scope:    &ast.Scope{
+		is_vls:           pref_.is_vls && path == pref_.path
+		is_vls_skip_file: pref_.is_vls && path != pref_.path
+		scope:            &ast.Scope{
 			start_pos: 0
 			parent:    table.global_scope
 		}
-		errors:   []errors.Error{}
-		warnings: []errors.Warning{}
-		file_idx: file_idx
+		errors:           []errors.Error{}
+		warnings:         []errors.Warning{}
+		file_idx:         file_idx
 	}
 	p.set_path(path)
 	res := p.parse()
@@ -318,7 +321,9 @@ pub fn (mut p Parser) parse() &ast.File {
 	}
 	for {
 		if p.tok.kind == .eof {
-			p.check_unused_imports()
+			if !p.is_vls_skip_file {
+				p.check_unused_imports()
+			}
 			break
 		}
 		stmt := p.top_stmt()

vlib/v/tests/vls/autocomplete_module_test.v

@@ -3,9 +3,11 @@ import term
 import v.util.diff
 
 const vroot = os.real_path(@VMODROOT)
+const tmp_dir = os.real_path(os.temp_dir())
 
 const text_file_orig = os.join_path(vroot, 'vlib', 'v', 'tests', 'vls', 'sample_text.vv')
-const text_file = os.join_path(os.temp_dir(), 'sample_text.v')
+const text_file = os.join_path(tmp_dir, 'sample_text.v')
+const text_file_result = $if windows { text_file.replace('\\', '/') } $else { text_file }
 
 fn testsuite_begin() {
 	eprintln('testsuite_begin, text_file = ${text_file}')
@@ -33,6 +35,82 @@ const test_data = [
 {"kind":21,"label":"public_const1","detail":"","documentation":""}
 ]}'
 	},
+	TestData{
+		cmd:    'v -w -vls-mode -check -json-errors ${os.quoted_path(text_file)}'
+		output: '[
+{
+"path":"${text_file}",
+"message":"undefined ident: `a`",
+"line_nr":14,
+"col":4,
+"len":0
+}
+,
+{
+"path":"${text_file}",
+"message":"operator `+=` not defined on left operand type `void`",
+"line_nr":14,
+"col":4,
+"len":0
+}
+,
+{
+"path":"${text_file}",
+"message":"cannot assign to `a`: expected `void`, not `int`",
+"line_nr":14,
+"col":9,
+"len":0
+}
+,
+{
+"path":"${text_file}",
+"message":"undefined ident: `s`",
+"line_nr":18,
+"col":2,
+"len":0
+}
+]
+'
+	},
+	TestData{
+		cmd:    'v -check -nocolor -vls-mode ${os.quoted_path(text_file)}'
+		output: '${text_file_result}:14:4: error: undefined ident: `a`
+   12 | // add add `val` to `a`
+   13 | fn (mut m MyS) add(val int) {
+   14 |     m.a += val
+      |       ^
+   15 | }
+   16 |
+${text_file_result}:14:4: error: operator `+=` not defined on left operand type `void`
+   12 | // add add `val` to `a`
+   13 | fn (mut m MyS) add(val int) {
+   14 |     m.a += val
+      |       ^
+   15 | }
+   16 |
+${text_file_result}:14:9: error: cannot assign to `a`: expected `void`, not `int`
+   12 | // add add `val` to `a`
+   13 | fn (mut m MyS) add(val int) {
+   14 |     m.a += val
+      |            ~~~
+   15 | }
+   16 |
+${text_file_result}:18:2: error: undefined ident: `s`
+   16 | 
+   17 | fn main() {
+   18 |     s.
+      |     ^
+   19 |     //sample_mod2.
+   20 |     //mut k := MyS{}
+${text_file_result}:5:8: warning: module \'sample_mod2 (v.tests.vls.sample_mod2)\' is imported but never used
+    3 | 
+    4 | import v.tests.vls.sample_mod1 as s
+    5 | import v.tests.vls.sample_mod2
+      |        ~~~~~~~~~~~~~~~~~~~~~~~
+    6 | 
+    7 | struct MyS{
+'
+	},
 ]
 
 fn test_main() {