markused: fix option ptr printing (fix #23559) (#23562)

felipensp · web-flow · commit da5bb68b619c · 2025-01-23T20:37:13.000+02:00
diff --git a/vlib/v/checker/fn.v b/vlib/v/checker/fn.v
@@ -759,7 +759,7 @@ fn (mut c Checker) call_expr(mut node ast.CallExpr) ast.Type {
 		c.markused_option_or_result(!c.is_builtin_mod && c.mod != 'strings')
 	}
 	c.expected_or_type = old_expected_or_type
-	c.markused_call_expr(mut node)
+	c.markused_call_expr(left_type, mut node)
 	if !c.inside_const && c.table.cur_fn != unsafe { nil } && !c.table.cur_fn.is_main
 		&& !c.table.cur_fn.is_test {
 		// TODO: use just `if node.or_block.kind == .propagate_result && !c.table.cur_fn.return_type.has_flag(.result) {` after the deprecation for ?!Type
diff --git a/vlib/v/checker/used_features.v b/vlib/v/checker/used_features.v
@@ -111,7 +111,7 @@ fn (mut c Checker) markused_comptimefor(mut node ast.ComptimeFor, unwrapped_expr
 	}
 }
 
-fn (mut c Checker) markused_call_expr(mut node ast.CallExpr) {
+fn (mut c Checker) markused_call_expr(left_type ast.Type, mut node ast.CallExpr) {
 	if !c.is_builtin_mod && c.mod == 'main' && !c.table.used_features.external_types {
 		if node.is_method {
 			if c.table.sym(node.left_type).is_builtin() {
@@ -121,6 +121,10 @@ fn (mut c Checker) markused_call_expr(mut node ast.CallExpr) {
 			c.table.used_features.external_types = true
 		}
 	}
+	if left_type != 0 && left_type.is_ptr() && !c.table.used_features.auto_str_ptr
+		&& node.name == 'str' {
+		c.table.used_features.auto_str_ptr = true
+	}
 }
 
 fn (mut c Checker) markused_fn_call(mut node ast.CallExpr) {
diff --git a/vlib/v/tests/skip_unused/option_ptr_print.run.out b/vlib/v/tests/skip_unused/option_ptr_print.run.out
@@ -0,0 +1 @@
+[vlib/v/tests/skip_unused/option_ptr_print.vv:7] hrefs.str(): &<div class="Truncate" >abc</div>
diff --git a/vlib/v/tests/skip_unused/option_ptr_print.skip_unused.run.out b/vlib/v/tests/skip_unused/option_ptr_print.skip_unused.run.out
@@ -0,0 +1 @@
+[vlib/v/tests/skip_unused/option_ptr_print.vv:7] hrefs.str(): &<div class="Truncate" >abc</div>
diff --git a/vlib/v/tests/skip_unused/option_ptr_print.vv b/vlib/v/tests/skip_unused/option_ptr_print.vv
@@ -0,0 +1,8 @@
+import net.html
+
+fn main() {
+	mut doc := html.parse('<body><div class="Box-footer"><div class="Truncate">abc</div></div></body>')
+	footer := doc.get_tags_by_class_name('Box-footer')[0]
+	hrefs := footer.get_tag_by_class_name('Truncate')
+	dump(hrefs?.str())
+}

Original file line number	Diff line number	Diff line change
`@@ -759,7 +759,7 @@ fn (mut c Checker) call_expr(mut node ast.CallExpr) ast.Type {`
`759`	`759`	`c.markused_option_or_result(!c.is_builtin_mod && c.mod != 'strings')`
`760`	`760`	`}`
`761`	`761`	`c.expected_or_type = old_expected_or_type`
`762`		`- c.markused_call_expr(mut node)`
	`762`	`+ c.markused_call_expr(left_type, mut node)`
`763`	`763`	`if !c.inside_const && c.table.cur_fn != unsafe { nil } && !c.table.cur_fn.is_main`
`764`	`764`	`&& !c.table.cur_fn.is_test {`
`765`	`765`	// TODO: use just `if node.or_block.kind == .propagate_result && !c.table.cur_fn.return_type.has_flag(.result) {` after the deprecation for ?!Type
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ fn (mut c Checker) markused_comptimefor(mut node ast.ComptimeFor, unwrapped_expr`
`111`	`111`	`}`
`112`	`112`	`}`
`113`	`113`
`114`		`-fn (mut c Checker) markused_call_expr(mut node ast.CallExpr) {`
	`114`	`+fn (mut c Checker) markused_call_expr(left_type ast.Type, mut node ast.CallExpr) {`
`115`	`115`	`if !c.is_builtin_mod && c.mod == 'main' && !c.table.used_features.external_types {`
`116`	`116`	`if node.is_method {`
`117`	`117`	`if c.table.sym(node.left_type).is_builtin() {`
`@@ -121,6 +121,10 @@ fn (mut c Checker) markused_call_expr(mut node ast.CallExpr) {`
`121`	`121`	`c.table.used_features.external_types = true`
`122`	`122`	`}`
`123`	`123`	`}`
	`124`	`+ if left_type != 0 && left_type.is_ptr() && !c.table.used_features.auto_str_ptr`
	`125`	`+ && node.name == 'str' {`
	`126`	`+ c.table.used_features.auto_str_ptr = true`
	`127`	`+ }`
`124`	`128`	`}`
`125`	`129`
`126`	`130`	`fn (mut c Checker) markused_fn_call(mut node ast.CallExpr) {`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+[vlib/v/tests/skip_unused/option_ptr_print.vv:7] hrefs.str(): &<div class="Truncate" >abc</div>`