Add orchestration create environment modal#10857
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a new orchestration environment creation entry point, a reusable create-environment modal, deferred GitHub repo loading, and related environment form configuration for orchestration surfaces.
Concerns
- This is a user-facing UI/layout change, but the PR description says screenshots/videos are not included and manual testing is unchecked. For this user-facing change, please include screenshots or a short screen recording demonstrating the environment picker entry point, modal creation flow, and post-create selection working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
|
@cephalonaut yeah i think that's a problem with the modal |
## Description Adds a “New environment” entry point to orchestration environment pickers and opens a create-environment modal based on the Agent orchestration design. This includes: - A reusable orchestration create-environment modal that creates the environment and selects it in the originating orchestration config. - Orchestration-specific copy/layout for the existing environment form, including compact modal spacing and footer actions. - Deferred GitHub repo loading when the modal opens. - Graceful GitHub repo load-error fallback so users can still paste repo URLs and retry repo discovery. <img width="756" height="462" alt="Screenshot 2026-05-18 at 12 25 18 PM" src="https://github.com/user-attachments/assets/903e35bc-e920-4f78-856d-d64b4f169e68" /> ## Linked Issue QUALITY-624 <!-- Link the GitHub issue this PR addresses. Before opening this PR, please confirm: --> - [ ] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. - [ ] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). ## Testing - [x] `cargo fmt -- --check` - [x] `cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings` - [x] `cargo clippy -p warp_completer --all-targets --tests -- -D warnings` - [x] `cargo check --manifest-path /Users/katarina/.warp/worktrees/warp/sagebrush-adobe/Cargo.toml -p warp --lib` - [x] `cargo test --manifest-path /Users/katarina/.warp/worktrees/warp/sagebrush-adobe/Cargo.toml -p warp update_environment_form --lib` - [x] `cargo test --manifest-path /Users/katarina/.warp/worktrees/warp/sagebrush-adobe/Cargo.toml -p warp run_agents_card_view --lib` - [x] `cargo test --manifest-path /Users/katarina/.warp/worktrees/warp/sagebrush-adobe/Cargo.toml -p warp orchestration_modal --lib` - [x] `git --no-pager diff --check` - [ ] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos Not included. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode ## Agent Artifacts - Conversation: https://app.warp.dev/conversation/55a7895a-b680-463d-ac6d-ce30c27769b1 - Plan: https://app.warp.dev/drive/notebook/rUQ8mlTKgGjFmTLUN2jOC4 ## Changelog Entries for Stable CHANGELOG-IMPROVEMENT: Added a create-environment flow to the orchestration environment picker. Co-Authored-By: Oz <oz-agent@warp.dev> --------- Co-authored-by: Oz <oz-agent@warp.dev>

Description
Adds a “New environment” entry point to orchestration environment pickers and opens a create-environment modal based on the Agent orchestration design.
This includes:
Linked Issue
QUALITY-624
ready-to-specorready-to-implement.Testing
cargo fmt -- --checkcargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningscargo clippy -p warp_completer --all-targets --tests -- -D warningscargo check --manifest-path /Users/katarina/.warp/worktrees/warp/sagebrush-adobe/Cargo.toml -p warp --libcargo test --manifest-path /Users/katarina/.warp/worktrees/warp/sagebrush-adobe/Cargo.toml -p warp update_environment_form --libcargo test --manifest-path /Users/katarina/.warp/worktrees/warp/sagebrush-adobe/Cargo.toml -p warp run_agents_card_view --libcargo test --manifest-path /Users/katarina/.warp/worktrees/warp/sagebrush-adobe/Cargo.toml -p warp orchestration_modal --libgit --no-pager diff --checkI have manually tested my changes locally with
./script/runScreenshots / Videos
Not included.
Agent Mode
Agent Artifacts
Changelog Entries for Stable
CHANGELOG-IMPROVEMENT: Added a create-environment flow to the orchestration environment picker.
Co-Authored-By: Oz oz-agent@warp.dev