Revert "Enable IME on Linux/Wayland (#9602)"#11032
Conversation
This reverts commit 543d54e. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR reverts the Linux-only set_ime_allowed(true) call added for Wayland IME support. The change is small, but it directly affects user-visible text input behavior on Linux/Wayland.
Concerns
- Removing
window.set_ime_allowed(true)appears to reintroduce the issue fixed by #9602/#9383: Wayland IME stays inactive and CJK/non-Latin input becomes unusable. - Because this is a user-facing input behavior change, please include screenshots or a short screen recording demonstrating the intended Linux/Wayland IME behavior end to end, along with manual test confirmation.
- Security pass: no actionable security concerns found in this diff.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| if let Ok(window) = created_window.as_ref() { | ||
| // On Linux/Wayland, winit only sends `zwp_text_input_v3.enable()` when IME is allowed, | ||
| // so without this call IME stays inactive and non-Latin input (CJK, etc.) is unusable. | ||
| window.set_ime_allowed(true); |
There was a problem hiding this comment.
zwp_text_input_v3.enable(), so CJK/non-Latin input remains unusable. Keep this behavior, replace it with a safer fix, or document why regressing #9383 is acceptable.
…in RELEASE_FLAGS - Remove ime_marked_text from gui feature (no external deps) - Add ime_marked_text to default feature list - Gate ImeMarkedText in RELEASE_FLAGS to macos/windows only (exclude Linux due to warpdotdev#11032) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
) ## Description Reverts warpdotdev#9602 ("Enable IME on Linux/Wayland"). This reverts merge commit `50582e910b9149055a1962e59e6f74acc703dbb4`, which added a `#[cfg(target_os = "linux")]` block in `crates/warpui/src/windowing/winit/window.rs::create_window` calling `window.set_ime_allowed(true)`. ## Linked Issue Revert of warpdotdev#9602 (originally closed warpdotdev#9383). ## Testing - [ ] I have manually tested my changes locally with `./script/run` This is a pure `git revert` of the original commit, restoring the previous behavior on Linux/Wayland. I can't really reproduce this but it's the only commit that seems to affect IME on Linux and Wayland in the last release. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode [Conversation](https://staging.warp.dev/conversation/4326abed-5c34-4366-8ddd-5eb51039886d) <!-- CHANGELOG-NONE --> Co-authored-by: Abhishek Pandya <lilimmwilson@gmail.com> Co-authored-by: Oz <oz-agent@warp.dev>
3 participants
Description
Reverts #9602 ("Enable IME on Linux/Wayland").
This reverts merge commit
543d54ecc6766a1c863419ded39c26d97307f5b4, which added a#[cfg(target_os = "linux")]block incrates/warpui/src/windowing/winit/window.rs::create_windowcallingwindow.set_ime_allowed(true).Linked Issue
Revert of #9602 (originally closed #9383).
Testing
./script/runThis is a pure
git revertof the original commit, restoring the previous behavior on Linux/Wayland.I can't really reproduce this but it's the only commit that seems to affect IME on Linux and Wayland in the last release.
Agent Mode
Conversation