Refine onboarding verification branch coverage#11328
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR expands the onboarding verification skill from two baseline logged-out/logged-in explorers into a bounded follow-up wave for branch coverage, with additional screenshot-backed reporting for suspicious UI states.
Concerns
- The second-wave
run_agentsexample omits the matching logged-in/logged-out flow prompt, which can cause follow-up agents to miss required auth handling, artifact directory, and flow-specific behavior.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| - name: "warp-onboarding-followup-theme-choice" | ||
| prompt: the follow-up flow prompt below plus one synthesized branch assignment | ||
| - name: "warp-onboarding-followup-model-choice" | ||
| prompt: the follow-up flow prompt below plus one synthesized branch assignment |
There was a problem hiding this comment.
| - name: "warp-onboarding-followup-theme-choice" | |
| prompt: the follow-up flow prompt below plus one synthesized branch assignment | |
| - name: "warp-onboarding-followup-model-choice" | |
| prompt: the follow-up flow prompt below plus one synthesized branch assignment | |
| - name: "warp-onboarding-followup-theme-choice" | |
| prompt: the follow-up flow prompt below, the logged-out flow prompt below, and one synthesized logged-out branch assignment | |
| - name: "warp-onboarding-followup-model-choice" | |
| prompt: the follow-up flow prompt below, the logged-in flow prompt below, and one synthesized logged-in branch assignment |
There was a problem hiding this comment.
Oz's feedback here seems legit given step 8 above.
captainsafia
left a comment
There was a problem hiding this comment.
Looks good but I think Oz's feedback is good to address here.
| - name: "warp-onboarding-followup-theme-choice" | ||
| prompt: the follow-up flow prompt below plus one synthesized branch assignment | ||
| - name: "warp-onboarding-followup-model-choice" | ||
| prompt: the follow-up flow prompt below plus one synthesized branch assignment |
There was a problem hiding this comment.
Oz's feedback here seems legit given step 8 above.
Co-Authored-By: Oz <oz-agent@warp.dev>
Summary
Validation
Conversation: https://staging.warp.dev/conversation/862a4563-4a63-4dfd-b5d8-aea28cbb5ac1
Co-Authored-By: Oz oz-agent@warp.dev