Downgrade missing snapshot script error log#11343
Conversation
A missing OZ_SNAPSHOT_DECLARATIONS_SCRIPT is expected in some paths (e.g. local dev without warp-agent-docker, non-containerized runs), so logging it at error level was noisy and misleading. Downgrade to log::info and update the doc comment accordingly. Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
changed the title
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR downgrades the missing OZ_SNAPSHOT_DECLARATIONS_SCRIPT environment variable path from an error log to an info log and updates the helper comment to match the existing non-fatal skip behavior. That aligns with the described local CLI path where declarations snapshotting can be intentionally unavailable.
Concerns
- No blocking correctness, spec-alignment, or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
2 participants
Description
It's expected that the snapshot declarations script won't always be available (for ex., when running an agent locally using the CLI), and we handle this case already by skipping snapshotting, so we can downgrade this to a regular info log (in case this comes up in debugging around missing snapshots and this info is useful to have).
As a side-note, users can also define their own snapshot scripts and expose them using this env variable so that we actually do do snapshotting for local CLI runs. I'll coordinate with @hongyi-chen about adding some docs for this, although I expect this to be a workflow that's only used by real oz power users.
Agent Mode
Conversation: https://staging.warp.dev/conversation/e1b66b0c-bbd1-4cda-a453-46c5009c435f
Run: https://oz.staging.warp.dev/runs/019e41bf-95b5-70f1-956f-07e6cd07faf0
This PR was generated with Oz.