Show orchestrator pill as in-progress while children run#11367

advait-m · 2026-05-19T23:36:12Z

Loom: https://www.loom.com/share/5011222654f54c348f5f460632abfd5e

Description

The orchestrator's own ConversationStatus flips to Success as soon as its own streaming turn finishes, even while spawned child agents are still running. That left the orchestration pill (and its hover-card badge) showing no status overlay at all — and the long-standing comment in render_hover_card ("Until we plumb an aggregated child-status accessor we hide the badge for the orchestrator pill") explicitly punted on it.

This PR plumbs the aggregated child-status accessor and feeds it to both the orchestrator pill's avatar overlay and the hover-card badge.

Aggregation precedence (highest wins):

InProgress — any node in the tree is actively running
Blocked — at least one node is waiting on user input (preserves the first blocked_action payload)
Error — at least one node finished with an error
Cancelled — at least one node was cancelled
Success — everything finished successfully

This means the orchestrator pill now stays "In progress" while any descendant is still running, surfaces "Blocked" when a descendant needs user attention, and falls back to the worst-case terminal outcome once everything has finished. Per design feedback: if anyone is still in-progress we never flip the orchestrator to a terminal status.

Testing

Unit tests: 6 new tests in orchestration_topology_tests.rs covering each precedence rule (in-progress wins over errored siblings; blocked wins over terminal states; error > cancelled > success; orchestrator's own InProgress is respected; all-Success case).
Manual: Local cargo fmt clean. cargo clippy / cargo nextest were not run locally — my Xcode is missing the Metal Toolchain so warpui's build.rs fails before reaching Rust code. Relying on CI for clippy + the unit tests above.

The orchestrator's own ConversationStatus flips to Success as soon as its own turn finishes, even while spawned child agents are still running. The orchestration pill (and its hover-card badge) ended up showing either no status or a misleading 'Done' state in that window. Plumb an aggregated child-status accessor (long noted as a TODO in the hover-card path) and feed it to both the orchestrator pill's avatar overlay and the hover card's status badge. Aggregation precedence: InProgress > Blocked > Error > Cancelled > Success, so the pill stays 'In progress' while anything is in flight, surfaces 'Blocked' when a descendant needs user attention, and falls back to the worst-case terminal outcome once everything has finished. Co-Authored-By: Oz <oz-agent@warp.dev>

…e_child comment - Hover card now keeps the child-pill path passing the status by reference (no clone). Orchestrator path holds an aggregated status by value in a deferred-init binding and borrows from it. - Drop redundant type annotations on badge_status / status_badge per WARP.md style. - Correct the is_remote_child comment on the orchestrator pill spec: the flag is a child-placeholder flag and never applies to the orchestrator. Cloud-to-cloud orchestration does exist, but surfacing remote orchestrators via the cloud overlay would need separate plumbing. Co-Authored-By: Oz <oz-agent@warp.dev>

…orchestrator-aggregated-status # Conflicts: # app/src/ai/blocklist/orchestration_topology_tests.rs

oz-for-oss · 2026-05-20T22:53:12Z

@advait-m

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds an aggregated orchestration status helper and uses it for the orchestrator pill avatar overlay and hover-card badge. The provided Loom link satisfies the visual-evidence requirement, and I did not find security issues in the changed code.

Concerns

The aggregation includes the orchestrator conversation's own terminal status, which can surface the unhelpful root Cancelled state after all child agents finish successfully.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-20T22:56:26Z

+    history: &BlocklistAIHistoryModel,
+    orchestrator_id: AIConversationId,
+) -> ConversationStatus {
+    let statuses = std::iter::once(orchestrator_id)


⚠️ [IMPORTANT] Including the root conversation in the terminal-state aggregation reintroduces the raw orchestrator Cancelled state the UI was hiding: after delegation, once all descendants finish successfully, the root Cancelled will beat Success and the pill will end as Cancelled even though the child tree succeeded. Treat the orchestrator's terminal status specially or aggregate terminal outcomes from descendants only.

disagree with this - this is intended, if the orchestrator is cancelled then this makes sense

cephalonaut

Sweet! My comments are mostly just about LLM comments - I feel like I'm constantly battling to reduce them to some sane level.

cephalonaut · 2026-05-22T19:02:27Z

+    // the available space (this used to happen on the orchestrator pill,
+    // whose title falls back to the conversation's multi-word title rather
+    // than a short agent name).
+    let name_max_width = HOVER_CARD_WIDTH - 24. - 16. - 8. - 8. - STATUS_BADGE_MAX_WIDTH;


Kinda unrelated, but the literals in this calculation should probably be named constants tied to the rendered values. That way we could also trim this massive comment back a bit!

agreed; fixed!

cephalonaut · 2026-05-22T19:04:08Z

-    // the orchestration as a whole. Until we plumb an aggregated
-    // child-status accessor we hide the badge for the orchestrator pill
-    // — child pills still show the (per-child accurate) badge.
+    // The orchestrator's raw `ConversationStatus` only reflects its own


Could probably trim much of this

cephalonaut · 2026-05-22T19:05:10Z

            kind: PillKind::Orchestrator,
            pin_state: PillPinState::Unpinned,
-            // Unused: orchestrator pills don't render a status overlay.
+            // `is_remote_child` is a child-placeholder flag and never applies


Excessive - seems logical that the orchestrator is not a child

agreed; trimming

cephalonaut · 2026-05-22T19:06:42Z

        let mut specs = Vec::with_capacity(1 + children.len());

        // Orchestrator pill first; never pinned (it's the home view).
+        // The pill's status badge reflects the orchestration tree as a whole


Too verbose? Maybe just a one liner above line 620: Orchestrator badge is aggregated with children's statuses?

agreed; changing

cephalonaut · 2026-05-22T19:07:13Z

        let leading: Box<dyn Element> = match kind {
            PillKind::Orchestrator => match status.as_ref() {
-                // Defensive: orchestrator pills don't currently carry a status.
+                // Orchestrator pills always carry an aggregated status (see


Just drop this comment

advait-m · 2026-05-22T19:51:12Z

Sweet! My comments are mostly just about LLM comments - I feel like I'm constantly battling to reduce them to some sane level.

haha yep - thanks for calling these out, fixing

…orchestrator-aggregated-status # Conflicts: # app/src/ai/blocklist/orchestration_topology_tests.rs Co-Authored-By: Oz <oz-agent@warp.dev>

cla-bot Bot added the cla-signed label May 19, 2026

advait-m and others added 2 commits May 19, 2026 16:49

Merge remote-tracking branch 'origin/master' into advait/quality-718-…

4e58615

…orchestrator-aggregated-status # Conflicts: # app/src/ai/blocklist/orchestration_topology_tests.rs

advait-m marked this pull request as ready for review May 20, 2026 22:53

oz-for-oss Bot reviewed May 20, 2026

View reviewed changes

advait-m requested a review from cephalonaut May 21, 2026 00:34

advait-m changed the title ~~[QUALITY-718] Show orchestrator pill as in-progress while children run~~ Show orchestrator pill as in-progress while children run May 21, 2026

cephalonaut approved these changes May 22, 2026

View reviewed changes

advait-m and others added 2 commits May 22, 2026 13:00

address comments

4fc9153

Merge remote-tracking branch 'origin/master' into advait/quality-718-…

dd129fc

…orchestrator-aggregated-status # Conflicts: # app/src/ai/blocklist/orchestration_topology_tests.rs Co-Authored-By: Oz <oz-agent@warp.dev>

advait-m merged commit 9064335 into master May 22, 2026
25 checks passed

advait-m deleted the advait/quality-718-orchestrator-aggregated-status branch May 22, 2026 21:36

advait-m mentioned this pull request May 22, 2026

UI Polish orchestration pill bar +segmented control to match Figma #11578

Open

Conversation

advait-m commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

oz-for-oss Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cephalonaut left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

advait-m commented May 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

advait-m commented May 19, 2026 •

edited

Loading

oz-for-oss Bot commented May 20, 2026 •

edited

Loading