Enable SoloUserByok and BillingAndUsagePageV2 in stable#11437
Merged
Conversation
Promotes both feature flags to production by enabling their Cargo features in the default build and removing them from DOGFOOD_FLAGS. Adds a new `billing_and_usage_page_v2` Cargo feature (with bridge in `enabled_features()`) since one didn't exist yet; `solo_user_byok` already had its Cargo feature wired up. Keeps the flags in place for a one-line rollback. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR promotes SoloUserByok and BillingAndUsagePageV2 into the default/stable client build by adding Cargo feature defaults, wiring BillingAndUsagePageV2 into enabled_features(), and removing both flags from dogfood-only rollout.
Concerns
- This is a user-facing stable rollout, but the PR description does not include screenshots or a screen recording demonstrating the enabled flows end to end. Repo review guidance requires visual evidence for user-visible behavior changes.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
tylerlam-warp
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Promotes the
SoloUserByokandBillingAndUsagePageV2feature flags to production for the client.For each flag:
billing_and_usage_page_v2) or reuses (solo_user_byok) the Cargo feature inapp/Cargo.toml'sdefault = [...]array, so it ships in stable builds.billing_and_usage_page_v2Cargo feature toFeatureFlag::BillingAndUsagePageV2inenabled_features()(solo_user_byokwas already wired).DOGFOOD_FLAGSincrates/warp_features/src/lib.rs.The flags themselves remain in the
FeatureFlagenum so rollback is a one-line revert of the entries indefault.Linked Issue
None.
Testing
cargo fmt --all✅cargo clippy --workspace --all-targets --all-features --tests -- -D warnings✅This is a feature rollout configuration change; behavior for both flags has been validated previously while they were in dogfood.
Agent Mode
Agent conversation:
https://staging.warp.dev/conversation/d95f54cf-cf49-405e-b5c2-252f23059479
Co-Authored-By: Oz oz-agent@warp.dev