Skip to content

Detect common skill updates during script/run#11455

Merged
zachlloyd merged 2 commits into
masterfrom
zach/skills-installer-fixes
May 22, 2026
Merged

Detect common skill updates during script/run#11455
zachlloyd merged 2 commits into
masterfrom
zach/skills-installer-fixes

Conversation

@zachlloyd
Copy link
Copy Markdown
Contributor

@zachlloyd zachlloyd commented May 20, 2026

Description

  • Remove script/run's local --verify-only fast path for common skills so normal runs always delegate update decisions to the shared common-skills installer.
  • This allows ./script/run to detect upstream warpdotdev/common-skills lock changes instead of silently skipping the upstream check when the installed copy matches the current lock.
  • Refresh skills-lock.json to the latest common-skills set, adding check-impl-against-spec, council, and reproduce-bug-report, and updating the review-pr hash.

The no-op path is still preserved by the shared installer: when the current lock and installed common-skills stamp already match, ./script/run proceeds without prompting or reinstalling.

Agent conversation: https://staging.warp.dev/conversation/15c99a45-ffd2-4d3c-9d6e-0267b310c115

Linked Issue

  • N/A — developer workflow fix

Testing

  • bash -n script/run
  • git diff --check
  • /Users/zach/Projects/common-skills/scripts/install_common_skills --repo-root /Users/zach/Projects/warp --verify-only --quiet
  • cargo fmt --all --check --manifest-path /Users/zach/Projects/warp/Cargo.toml
  • cargo clippy --workspace --all-targets --all-features --tests -- -D warnings
  • Manually exercised ./script/run with an available common-skills update; it prompted to refresh the lock, reinstalled, and continued into the app build.
  • Manually exercised ./script/run again after the lock/install state matched; it proceeded directly into the app build without prompting for common-skills installation.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label May 20, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 20, 2026

@zachlloyd

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR routes normal ./script/run common-skills setup through the installer --if-needed path so interactive runs can detect and accept upstream common-skill lock updates, and refreshes skills-lock.json to the latest accepted common-skills lock.

Concerns

  • No blocking correctness, security, or spec-alignment concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@zachlloyd zachlloyd requested a review from peicodes May 22, 2026 17:20
@zachlloyd zachlloyd merged commit 1201c0f into master May 22, 2026
31 checks passed
@zachlloyd zachlloyd deleted the zach/skills-installer-fixes branch May 22, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants