Fix typos#9318
Merged
Merged
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @antonkesy on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I approved this pull request and requested human review from: @kevinyang372, @zachbai, @seemeroland. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR fixes typos across comments, docs, logs/error messages, tests, and a few user-facing strings without changing control flow or data handling.
Concerns
- Minor grammar cleanup remains in
crates/markdown_parser/src/html_parser.rs.
Verdict
Found: 0 critical, 0 important, 1 suggestion
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| } | ||
|
|
||
| // Parse a HMTL style string into its corresponding name -> value hashmap | ||
| // Parse a HTML style string into its corresponding name -> value hashmap |
Contributor
There was a problem hiding this comment.
🧹 [NIT] Use an HTML because HTML starts with a vowel sound.
Suggested change
| // Parse a HTML style string into its corresponding name -> value hashmap | |
| // Parse an HTML style string into its corresponding name -> value hashmap |
seemeroland
approved these changes
Apr 28, 2026
Contributor
seemeroland
left a comment
seemeroland
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
alokedesai
added a commit
that referenced
this pull request
Apr 29, 2026
## Description While reading through a few crates I kept noticing duplicated words in comments — "the the", "in in", "to to", "and and", "a a", "that that". A quick `grep` turned up 17 of them across 15 files. All edits are in `//` and `///` comments — no code, test, or behavior change. Files touched: - `crates/settings/src/manager.rs` - `crates/websocket/src/sink_map_err.rs` - `crates/warp_completer/src/completer/suggest/test.rs` - `crates/warp_completer/src/completer/engine/argument/legacy.rs` - `crates/warp_completer/src/completer/engine/argument/v2.rs` - `crates/warp_core/src/ui/color/contrast.rs` - `crates/warp_logging/src/wasm.rs` - `crates/warpui_core/src/core/app.rs` - `crates/warpui_core/src/elements/selectable_area.rs` - `crates/warpui_core/src/elements/flex/mod_test.rs` - `crates/warpui/src/platform/mac/text_layout_test.rs` - `crates/warpui/src/platform/mac/rendering/wgpu/mod.rs` - `crates/warpui/src/platform/app.rs` - `crates/warpui/src/windowing/winit/fonts/font_handle.rs` - `crates/warpui/src/fonts/text_layout_test.rs` Distinct from #9318, which sweeps single-word misspellings (Surpress, occassionally, etc.) under `app/`. I also skipped the two doubled-word lines in `crates/integration/src/test.rs` since #9279 is currently editing that file — happy to fold them in if that PR lands first. ## Testing Comments-only. --------- Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com> Co-authored-by: Aloke Desai <aloke.desai@gmail.com> Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
captainsafia
added
the
external-contributor
Warp Dev Github Integration
zerx-lab
pushed a commit
to zerx-lab/zap
that referenced
this pull request
May 3, 2026
## Description While reading through a few crates I kept noticing duplicated words in comments — "the the", "in in", "to to", "and and", "a a", "that that". A quick `grep` turned up 17 of them across 15 files. All edits are in `//` and `///` comments — no code, test, or behavior change. Files touched: - `crates/settings/src/manager.rs` - `crates/websocket/src/sink_map_err.rs` - `crates/warp_completer/src/completer/suggest/test.rs` - `crates/warp_completer/src/completer/engine/argument/legacy.rs` - `crates/warp_completer/src/completer/engine/argument/v2.rs` - `crates/warp_core/src/ui/color/contrast.rs` - `crates/warp_logging/src/wasm.rs` - `crates/warpui_core/src/core/app.rs` - `crates/warpui_core/src/elements/selectable_area.rs` - `crates/warpui_core/src/elements/flex/mod_test.rs` - `crates/warpui/src/platform/mac/text_layout_test.rs` - `crates/warpui/src/platform/mac/rendering/wgpu/mod.rs` - `crates/warpui/src/platform/app.rs` - `crates/warpui/src/windowing/winit/fonts/font_handle.rs` - `crates/warpui/src/fonts/text_layout_test.rs` Distinct from warpdotdev#9318, which sweeps single-word misspellings (Surpress, occassionally, etc.) under `app/`. I also skipped the two doubled-word lines in `crates/integration/src/test.rs` since warpdotdev#9279 is currently editing that file — happy to fold them in if that PR lands first. ## Testing Comments-only. --------- Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com> Co-authored-by: Aloke Desai <aloke.desai@gmail.com> Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
zerx-lab
pushed a commit
to zerx-lab/zap
that referenced
this pull request
May 3, 2026
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> Fixes typos in comments, docs and strings _Sorry for the big and spammy PR_ ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? If you're not sure whether you should add a test, check our testing policy: https://www.notion.so/warpdev/How-We-Code-at-Warp-257fe43d556e4b3c8dfd42f70004cc72#1f97825450504baa9c5fd87a737daa09 --> None ## Server API dependencies <!-- You may remove this section if your PR does not have any server dependencies. --> - [ ] Is this change necessary to make the client compatible with a desired [server API breaking change](https://www.notion.so/warpdev/How-to-safely-introduce-server-API-breaking-changes-0aa805ff5d5d41fd8834f3c95caba0b4?pvs=4#d55ecf8aea3449949d3c33b0e67f6800)? - [ ] Does this change rely on a [new server API](https://www.notion.so/warpdev/How-to-add-a-new-full-stack-feature-8412cede405a4ec194b32bdd4b951035?pvs=4#04da1e6a493542d68b3e998c7d339640)? - [ ] If so, is the use of this API restricted to client channels that rely on the staging server (e.g. WarpDev)? - [ ] Is this change enabling the use of a server API on client channels that rely on the production server (e.g. WarpStable)? - [ ] If so, has the new server API been stable on production for at least one server release cycle? See [here](https://www.notion.so/warpdev/How-to-add-a-new-full-stack-feature-8412cede405a4ec194b32bdd4b951035?pvs=4#73b202f939834b97ab1fbdf7fc82cd53) for more details. ## Agent Mode - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
1 task
timomak
pushed a commit
to timomak/twarp
that referenced
this pull request
May 11, 2026
<!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> Fixes typos in comments, docs and strings _Sorry for the big and spammy PR_ <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? If you're not sure whether you should add a test, check our testing policy: https://www.notion.so/warpdev/How-We-Code-at-Warp-257fe43d556e4b3c8dfd42f70004cc72#1f97825450504baa9c5fd87a737daa09 --> None <!-- You may remove this section if your PR does not have any server dependencies. --> - [ ] Is this change necessary to make the client compatible with a desired [server API breaking change](https://www.notion.so/warpdev/How-to-safely-introduce-server-API-breaking-changes-0aa805ff5d5d41fd8834f3c95caba0b4?pvs=4#d55ecf8aea3449949d3c33b0e67f6800)? - [ ] Does this change rely on a [new server API](https://www.notion.so/warpdev/How-to-add-a-new-full-stack-feature-8412cede405a4ec194b32bdd4b951035?pvs=4#04da1e6a493542d68b3e998c7d339640)? - [ ] If so, is the use of this API restricted to client channels that rely on the staging server (e.g. WarpDev)? - [ ] Is this change enabling the use of a server API on client channels that rely on the production server (e.g. WarpStable)? - [ ] If so, has the new server API been stable on production for at least one server release cycle? See [here](https://www.notion.so/warpdev/How-to-add-a-new-full-stack-feature-8412cede405a4ec194b32bdd4b951035?pvs=4#73b202f939834b97ab1fbdf7fc82cd53) for more details. - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
timomak
added a commit
to timomak/twarp
that referenced
this pull request
May 11, 2026
…d73-fix-typos-9318 [twarp upstream/edit] Fix typos (warpdotdev#9318)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes typos in comments, docs and strings
Sorry for the big and spammy PR
Testing
None
Server API dependencies
Agent Mode