Skip to content

feat: show current zoom level while zooming#9689

Open
oz-for-oss[bot] wants to merge 2 commits into
masterfrom
oz-agent/spec-issue-9576
Open

feat: show current zoom level while zooming#9689
oz-for-oss[bot] wants to merge 2 commits into
masterfrom
oz-agent/spec-issue-9576

Conversation

@oz-for-oss
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot commented Apr 30, 2026

Closes #9576

Summary

  • Add a transient top-centered workspace HUD showing the current UI zoom percentage after zoom in, zoom out, and reset actions.
  • Share zoom stepping logic with tests so min/max clamps still report the current clamped value and invalid stored zoom values do not show the HUD.
  • Apply zoom factor changes from workspace window-settings updates so keybinding-driven zoom changes take effect immediately.

Validation

  • cargo test --manifest-path /workspace/warp/Cargo.toml -p warp adjusted_zoom_level
  • cargo fmt --manifest-path /workspace/warp/Cargo.toml -- app/src/workspace/view.rs app/src/workspace/view/zoom_level_hud.rs could not run because cargo-fmt/rustfmt is not installed in this environment.

Co-Authored-By: Kait <100063447+gurpreetkaits@users.noreply.github.com>
Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Apr 30, 2026
@oz-by-warp oz-by-warp Bot force-pushed the oz-agent/spec-issue-9576 branch from aa32027 to dae1131 Compare April 30, 2026 23:39
@oz-for-oss
Copy link
Copy Markdown
Contributor Author

oz-for-oss Bot commented Apr 30, 2026

@oz-for-oss[bot]

I'm starting a first review of this spec-only pull request.

You can view the conversation on Warp.

I completed the review and posted feedback on this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor Author

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This spec PR adds product and technical specs for a transient, non-interactive zoom-level HUD shown after user-initiated zoom actions. The product spec covers goals, non-goals, UX behavior, boundaries, validation, and open design questions; the tech spec maps the behavior to the existing zoom model, workspace action paths, overlay rendering approach, tests, risks, and follow-ups.

Concerns

  • No blocking concerns found for completeness, clarity, feasibility, issue alignment, internal consistency, or high-level security.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@zachlloyd zachlloyd added the plan-approved Indicates that the spec proposed in the PR is the approved one for the implementation. label May 23, 2026
Co-Authored-By: Oz <oz-agent@warp.dev>

Co-Authored-By: Zach Lloyd <zachlloyd@users.noreply.github.com>
@oz-for-oss oz-for-oss Bot changed the title spec: show current zoom level when zooming feat: show current zoom level while zooming May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed plan-approved Indicates that the spec proposed in the PR is the approved one for the implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show current zoom level (%) when zooming in/out

2 participants