Support --adapt-slug to override the default directory when installing zips
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Handle extension activation for WP error or extension not found
…-alert Display warning in plugin list info if plugin version is higher than expected
Move PHP 5.4 tests from `WP_VERSION` `latest` to `5.1`
Fix the wp-cli#166 bug: the "wp theme search" command has not the "page" option
Enhancement: Add PHP 7.3 to Travis CI build matrix
Update .distignore and .gitignore with phpcs/phpunit config files Update wp-cli-tests to 2.1
src/WP_CLI/DestructivePluginUpgrader.php src/WP_CLI/DestructiveThemeUpgrader.php
Update ruleset to exclude UselessOverridingMethod sniff
Update array syntax for changed lines
Implement CS checking based on the `WP_CLI_CS` ruleset
…add/mu-plugin-title
…command into add/mu-plugin-title
…staller Add `"johnpbloch/wordpress-core-installer": true` to `composer.json`
Co-authored-by: Pascal Birchler <[email protected]>
Add optional `--exclude=<name>` argument for multiple plugin commands
Regenerate README file
…ing zips The `install` subcommand for both plugins and themes now support the following: * `wp [plugin|theme] install whatever.zip --adapt-slug=bork` - When installing a zip (whether remote or local), the directory it gets installed to will be the value in `adapt-slug`; in this case, `bork/`' * `wp [plugin|theme] install whatever.zip --adapt-slug` - When installing a zip (whether remote or local), the plugin or theme name will be fetched from the bootstrap file or style.css respectively, slug-ify it, and then use that as the directory it gets installed to.
Member
|
@borkweb Looks pretty great so far! I kicked off the test suite to see if there are any side effects. What do you think should happen for |
Author
|
@danielbachhuber - Oh! I that's a great question. Erroring makes a lot of sense. |
Member
|
@borkweb Sounds good. Can you add a test case for that scenario? It looks like there's a coding standards issue that needs to be fixed too. |
Member
|
Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/6d013dbff6c939165c4c03c34b6477a1 in case this PR is auto-closed or broken in some way. |
danielbachhuber
force-pushed
the
master
branch
from
98fbf53 to
a07cad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
installsubcommand for both plugins and themes now support the following:wp [plugin|theme] install whatever.zip --adapt-slug=bork- When installing a zip (whether remote or local), the directory it gets installed to will be the value inadapt-slug; in this case,bork/'wp [plugin|theme] install whatever.zip --adapt-slug- When installing a zip (whether remote or local), the plugin or theme name will be fetched from the bootstrap file or style.css respectively, slug-ify it, and then use that as the directory it gets installed to.Fixes: #74