GH-38332: [CI][Release] Resolve symlinks in RAT lint#38337
Merged
Conversation
|
|
Member
Author
|
I confirmed that the original problem can be caught by CI: https://github.com/apache/arrow/actions/runs/6568194718/job/17842233859?pr=38337#step:5:941 I'll fix the problem. |
Member
Author
Member
|
@raulcd Could you review this? |
raulcd
reviewed
Oct 19, 2023
github-actions
Bot
added
awaiting changes
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
raulcd
approved these changes
Oct 19, 2023
github-actions
Bot
added
awaiting change review
raulcd
added
awaiting merge
github-actions
Bot
added
awaiting merge
raulcd
added a commit
that referenced
this pull request
Oct 19, 2023
### Rationale for this change Our release script (`dev/release/02-source.sh`) resolves symlinks in source archive but our lint script (`dev/archery/archery/utils/source.py`) doesn't resolve symlinks. So we may detect RAT problem by our CI. ### What changes are included in this PR? Resolve symlinks in our lint script too. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #38332 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3cf96b3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
) ### Rationale for this change Our release script (`dev/release/02-source.sh`) resolves symlinks in source archive but our lint script (`dev/archery/archery/utils/source.py`) doesn't resolve symlinks. So we may detect RAT problem by our CI. ### What changes are included in this PR? Resolve symlinks in our lint script too. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38332 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
) ### Rationale for this change Our release script (`dev/release/02-source.sh`) resolves symlinks in source archive but our lint script (`dev/archery/archery/utils/source.py`) doesn't resolve symlinks. So we may detect RAT problem by our CI. ### What changes are included in this PR? Resolve symlinks in our lint script too. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38332 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Our release script (
dev/release/02-source.sh) resolves symlinks in source archive but our lint script (dev/archery/archery/utils/source.py) doesn't resolve symlinks. So we may detect RAT problem by our CI.What changes are included in this PR?
Resolve symlinks in our lint script too.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.