Skip to content

Support shared config that forbids require()#15233

Merged
fisker merged 5 commits into
prettier:mainfrom
fisker:15195
Aug 29, 2023
Merged

Support shared config that forbids require()#15233
fisker merged 5 commits into
prettier:mainfrom
fisker:15195

Conversation

@fisker

@fisker fisker commented Aug 11, 2023

Copy link
Copy Markdown
Member

Description

Fixes #15195

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as ready for review August 11, 2023 09:56
@fisker

fisker commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

@sosukesuzuki Can you review? We can include this in patch release.

@sosukesuzuki sosukesuzuki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fisker fisker merged commit a35008f into prettier:main Aug 29, 2023
@fisker fisker deleted the 15195 branch August 29, 2023 08:11
@Hulmey

Hulmey commented Aug 29, 2023

Copy link
Copy Markdown

@sosukesuzuki Can you review? We can include this in patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prettier 3.x - Package subpath is not defined

3 participants