Update docs to 2021 edition, test#577
Merged
Merged
Conversation
Thomasdezeeuw
approved these changes
Aug 20, 2023
Thomasdezeeuw
left a comment
Thomasdezeeuw
left a comment
Collaborator
There was a problem hiding this comment.
LTGTM. The reasons the docs to use edition 2015 is because we recently bumped our MSRV from 1.31 to 1.60 in 0.4.19 (#552).
| //! ### Examples | ||
| //! | ||
| //! ```edition2018 | ||
| //! ```edition2021 |
Collaborator
There was a problem hiding this comment.
I think this can just be removed everywhere.
Suggested change
| //! ```edition2021 | |
| //! ``` |
Contributor
Author
|
@Thomasdezeeuw I think they should be removed after #580, or else they will continue using 2015 which i think is a bit confusing |
Contributor
|
We can probably merge #580 first, and then circle back to this one. |
Contributor
Author
|
Now that #580 is merged, I updated this PR to remove the editions and also add the 580's forgotten changelog entry. This one should be far easier to review :) |
* Inline format arg in documentation and a few call places * Add a unit test for inlined format args I was surprised to discover that log crate has no edition value... Any reason to keep it at 2015?
Contributor
Author
|
@Thomasdezeeuw and @KodrAus a friendly ping. I just rebased it just to keep it current. Let me know if any changes are needed. Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was surprised to discover that log crate has no edition value... Any reason to keep it at 2015?