fix(router): Ensure canceledNavigationResolution: 'computed' works …#51441
Closed
atscott wants to merge 2 commits intoangular:mainfrom
Closed
fix(router): Ensure canceledNavigationResolution: 'computed' works …#51441atscott wants to merge 2 commits intoangular:mainfrom
canceledNavigationResolution: 'computed' works …#51441atscott wants to merge 2 commits intoangular:mainfrom
Conversation
…on first page Setting the page ID is currently broken for the first page because the helper method's second parameter is optional, which allowed the initally `undefined` page ID to be used again when the router performs its initial navigation. fixes angular#50983
atscott
added
target: patch
… works on first page
atscott
force-pushed
the
initialnavigationcomputed
branch
from
f23e5ff to
686bab2
Compare
Contributor
|
This PR was merged into the repository by commit 96d94ad. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…on first page (angular#51441) Setting the page ID is currently broken for the first page because the helper method's second parameter is optional, which allowed the initally `undefined` page ID to be used again when the router performs its initial navigation. fixes angular#50983 PR Close angular#51441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on first page
Setting the page ID is currently broken for the first page because the helper method's second parameter is optional, which allowed the initally
undefinedpage ID to be used again when the router performs its initial navigation.fixes #50983