fix(material/dialog): update aria-labelledby if title is swapped#27609
Merged
crisbeto merged 1 commit intoangular:mainfrom Aug 10, 2023
Merged
fix(material/dialog): update aria-labelledby if title is swapped#27609crisbeto merged 1 commit intoangular:mainfrom
crisbeto merged 1 commit intoangular:mainfrom
Conversation
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
josephperrott
as code owners
crisbeto
commented
Aug 9, 2023
| '[id]': '_config.id', | ||
| '[attr.role]': '_config.role', | ||
| '[attr.aria-labelledby]': '_config.ariaLabel ? null : _ariaLabelledBy', | ||
| '[attr.aria-labelledby]': '_config.ariaLabel ? null : _ariaLabelledByQueue[0]', |
Member
Author
There was a problem hiding this comment.
Note that aria-labelledby supports passing a list of IDs so we could've also used all the IDs here, but I think that for the dialog case it makes sense to only have one label at a time.
crisbeto
force-pushed
the
27599/dialog-swap-title
branch
from
6c3dda0 to
0f99294
Compare
andrewseguin
approved these changes
Aug 9, 2023
Contributor
andrewseguin
left a comment
andrewseguin
left a comment
There was a problem hiding this comment.
Weird to have to use a queue but I see why
crisbeto
force-pushed
the
27599/dialog-swap-title
branch
from
0f99294 to
dd50f2e
Compare
Currently the dialog assigns the ID of the title as the `aria-labelleledby` of the container, but it doesn't update it if the title is swapped out or removed. These changes add a queue of possible IDs that the container can use as titles are being created or destroyed. Fixes angular#27599.
crisbeto
force-pushed
the
27599/dialog-swap-title
branch
from
dd50f2e to
40a011a
Compare
crisbeto
added a commit
that referenced
this pull request
Aug 10, 2023
) Currently the dialog assigns the ID of the title as the `aria-labelleledby` of the container, but it doesn't update it if the title is swapped out or removed. These changes add a queue of possible IDs that the container can use as titles are being created or destroyed. Fixes #27599. (cherry picked from commit 642d886)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the dialog assigns the ID of the title as the
aria-labelleledbyof the container, but it doesn't update it if the title is swapped out or removed.These changes add a queue of possible IDs that the container can use as titles as they are being created or destroyed.
Fixes #27599.