Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: Implement ES256 for JWT verification#340

Merged
arithmetic1728 merged 9 commits into
masterfrom
add-ec256-crypto
Apr 1, 2020
Merged

feat: Implement ES256 for JWT verification#340
arithmetic1728 merged 9 commits into
masterfrom
add-ec256-crypto

Conversation

@theacodes
Copy link
Copy Markdown
Contributor

Closes #336
Closes #157

@theacodes theacodes requested review from busunkim96 and crwilcox May 9, 2019 04:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2019
@theacodes theacodes changed the title Implement EC256 for JWT verification Implement ES256 for JWT verification May 9, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 16, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@arithmetic1728 arithmetic1728 changed the title Implement ES256 for JWT verification feat: Implement ES256 for JWT verification Mar 11, 2020
@arithmetic1728 arithmetic1728 requested a review from bshaffer March 12, 2020 01:49
Copy link
Copy Markdown
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fantastic. One clarification question, and also, seems like we should add a bit to the ID Token docs

Comment thread google/auth/jwt.py
@arithmetic1728
Copy link
Copy Markdown
Contributor

This all looks fantastic. One clarification question, and also, seems like we should add a bit to the ID Token docs

Yes. docs are now added.

Copy link
Copy Markdown
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@arithmetic1728 arithmetic1728 merged commit e290a3d into master Apr 1, 2020
@arithmetic1728 arithmetic1728 deleted the add-ec256-crypto branch April 1, 2020 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JWT can't be verified Support Elliptic curve signatures in JWT module

5 participants