Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs(bigquery): add docstring for conflict exception#171

Merged
plamut merged 3 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_issue_123_conflict_errors
Jul 20, 2020
Merged

docs(bigquery): add docstring for conflict exception#171
plamut merged 3 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_issue_123_conflict_errors

Conversation

@HemangChothani
Copy link
Copy Markdown
Contributor

Fixes #123

@HemangChothani HemangChothani requested a review from plamut July 16, 2020 11:31
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2020
Copy link
Copy Markdown
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing colons the changes look good. Samples test failures are irrelevant, as the samples have not been migrated yet.

Comment thread google/cloud/bigquery/client.py Outdated
A new ``Dataset`` returned from the API.

Raises:
google.cloud.exceptions.Conflict
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colons are missing at the end of exception types.

@plamut plamut merged commit 9c3409b into googleapis:master Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: client.create_table raises Conflict instead of AlreadyExists

2 participants