gh-67790: Add integer-style formatting for fractions.Fraction#2
Closed
mdickinson wants to merge 2 commits intomainfrom
Closed
gh-67790: Add integer-style formatting for fractions.Fraction#2mdickinson wants to merge 2 commits intomainfrom
mdickinson wants to merge 2 commits intomainfrom
Conversation
Owner
Author
|
(Not very) wild idea: we could add a new alignment type |
3b65369 to
130c717
Compare
Owner
Author
|
Re-opened as python#111320 |
Owner
Author
Not doing this - no-one has asked for it, and there are some details that are unclear (like where the sign should go). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept PR that extends python#100161 to add support for the 'd' presentation type in
fractions.Fraction.__format__.Detailed changes
'd'presentation type, supporting alignment, fill, sign and minimum width in the obvious-ish way (minimum width applies to the whole formatted number).#alternate formatting, which always includes a slash and denominator (by default, if the denominator is1then the slash and denominator are left out).'d'the default presentation type: a missing presentation type behaves identically to'd'.Feature complete and tested, but not yet ready to merge - it still needs doc updates.
To do