Skip to content

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Nov 13, 2021

A new reason property was recently added to the AbortSignal spec.

const ac = new AbortController();
ac.abort(new Error('boom!'));
console.loc(ac.signal.reason);  // Error('boom!');

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 13, 2021
@nodejs-github-bot

This comment has been minimized.

@aduh95

This comment has been minimized.

Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs more docs and tests (and wpts) but can be done later :)

@Trott Trott mentioned this pull request Nov 15, 2021
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 18, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@jasnell
Copy link
Member Author

jasnell commented Nov 20, 2021

@nodejs/build ... hey all, are the failures in the arm cluster a known issue?

@jasnell jasnell force-pushed the abortsignal-reason branch 3 times, most recently from 3428ae9 to e6b7b6f Compare November 20, 2021 21:01
@benjamingr benjamingr added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 21, 2021
@jasnell
Copy link
Member Author

jasnell commented Nov 24, 2021

Landed in 7633c86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abortcontroller Issues and PRs related to the AbortController API author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants