-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
lib: add reason to AbortSignal #40807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
Nov 13, 2021
jasnell
commented
Nov 13, 2021
jasnell
commented
Nov 13, 2021
41 tasks
benjamingr
approved these changes
Nov 14, 2021
Member
benjamingr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs more docs and tests (and wpts) but can be done later :)
lpinca
approved these changes
Nov 14, 2021
44 tasks
JungMinu
approved these changes
Nov 15, 2021
Merged
This was referenced Nov 16, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
31 tasks
ronag
approved these changes
Nov 19, 2021
47 tasks
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@nodejs/build ... hey all, are the failures in the arm cluster a known issue? |
3428ae9 to
e6b7b6f
Compare
41 tasks
Member
Author
|
Landed in 7633c86 |
This was referenced Nov 25, 2021
27 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
abortcontroller
Issues and PRs related to the AbortController API
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
semver-minor
PRs that contain new features and should be released in the next minor version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new reason property was recently added to the AbortSignal spec.