[3.8] bpo-41247: asyncio.set_running_loop() cache running loop holder (GH-21401) #21403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onGH-21401) The running loop holder cache variable was always set to NULL when calling set_running_loop. Now set_running_loop saves the newly created running loop holder in the cache variable for faster access in get_running_loop. Automerge-Triggered-By: @1st1 (cherry picked from commit 529f426) Co-authored-by: Tony Solomonik <[email protected]>
1st1
approved these changes
Jul 8, 2020
Contributor
Author
|
@tontinton: Status check is done, and it's a failure ❌ . |
Contributor
I've created a branch with the same fix only on 3.8, but github has issues right now, so I'll update when the PR is up, I will probably edit this comment with the PR link or something PR: #21406 |
Contributor
Author
|
@tontinton: Status check is done, and it's a failure ❌ . |
2 similar comments
Contributor
Author
|
@tontinton: Status check is done, and it's a failure ❌ . |
Contributor
Author
|
@tontinton: Status check is done, and it's a failure ❌ . |
Contributor
Author
|
@tontinton: Status check is done, and it's a failure ❌ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The running loop holder cache variable was always set to NULL when
calling set_running_loop.
Now set_running_loop saves the newly created running loop holder in the
cache variable for faster access in get_running_loop.
Automerge-Triggered-By: @1st1
(cherry picked from commit 529f426)
Co-authored-by: Tony Solomonik [email protected]
https://bugs.python.org/issue41247
Automerge-Triggered-By: @1st1