-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
bpo-31452: fix asyncio.gather does not cancel tasks if one fails #3597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
asvetlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwarunek your PR looks good but please do formal requirements: sign CLA and add news entry.
https://github.com/python/cpython/pull/3597/files#diff-33471390d839efb818436e087da26388L2224 covers the problem pretty well.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
I didn't expect the Spanish Inquisition! |
|
Nobody expects the Spanish Inquisition! @asvetlov: please review the changes made to this pull request. |
asvetlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@1st1 I'll merge the PR if you have no objections |
|
Will review it today |
1st1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to confirm this with Guido first.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Closing this PR because the corresponding issue was rejected. |
Currently if one task fail
asyncio.gather(withoutreturn_exception) leaves the rest of tasks pending instead of cancel them.https://bugs.python.org/issue31452