feat: extract all Electron specififc logic to plugins#21
Closed
MarshallOfSound wants to merge 1 commit intomainfrom
Closed
feat: extract all Electron specififc logic to plugins#21MarshallOfSound wants to merge 1 commit intomainfrom
MarshallOfSound wants to merge 1 commit intomainfrom
Conversation
* Website URL * Repo URL * Filename (now api.json) * Process information BREAKING CHANGE
MarshallOfSound
force-pushed
the
plugins
branch
from
0504658 to
b9cc8e4
Compare
Member
|
Is this mergeable? I'd be happy to help implement |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
To replicate the old Electron file you now use
electron-docs-parser \ --dir ../electron/src/electron \ --plugin url-provider \ --url-provider.websiteDocsBaseURL="https://electronjs.org" \ --url-provider.repoDocsBaseURL="https://github.com/electron/electron/blob" \ --plugin electron-processTODO:
.docsparser.jsonfile or similar