fix: close singleton editors when using 'Copy into New Window'#284685
Closed
Rani367 wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: close singleton editors when using 'Copy into New Window'#284685Rani367 wants to merge 1 commit intomicrosoft:mainfrom
Rani367 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Singleton editors (webviews, terminals, etc.) cannot be duplicated. When using 'Copy into New Window', the original editor is now closed, effectively making it a move operation. This fixes issues where: - Both windows were synced (same webview instance shared) - Performance lag/glitching occurred in animations Fixes microsoft#284525
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Author
@microsoft-github-policy-service agree |
bpasero
requested changes
Dec 28, 2025
Member
bpasero
left a comment
There was a problem hiding this comment.
This change seems to break terminal editors badly:
- apply this change
- create a new terminal in editor
- type
ls - select "Copy into new window"
- close the window
=> I see a terminal tab opened that I cannot click on.
Kapture.2025-12-28.at.07.42.46.mp4
Member
|
Besides, I cannot reproduce any issue with terminals or webview editors (such as markdown preview). |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes singleton editors (webviews, terminals, etc.) being shared between
windows when using "Copy into New Window".
Problem
When using "Copy into New Window" on a webview editor (like the integrated browser):
Solution
Treat singleton editors as moves even when the action is "copy" -
the original editor is closed after opening in the new window.
Test Plan
Fixes #284525