Repository navigation
Avoid repeated array merges in prompt formatting - #650
Open
andreybolonin wants to merge 1 commit into
Open
andreybolonin wants to merge 1 commit into
andreybolonin wants to merge 1 commit into
Conversation
andreybolonin
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 2, 2026 07:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixed prompt results repeatedly copy a growing message array through
array_merge. Append each formatted message directly while preserving numeric-key reindexing and string-key replacement. A unit test covers nested keys, order, and object identity.Local PHP 8.5 benchmark (500 items, 100 iterations): 65.6 → 28.2 ms, with lower peak additional memory (136.9 → 124.6 KB). This measures the affected operation, not full request latency.
Validation:
make ci(Composer update, PHP CS Fixer, PHPStan, PHPUnit).