Skip to content

Set "python.linting.pylintEnabled": false in package.json. #3007

Closed
Closed
Set "python.linting.pylintEnabled": false in package.json.#3007
Assignees
rchiodokimadeline
Labels
area-lintingfeature-requestRequest for new features or functionalityimportantIssue identified as high-priorityverification-neededVerification of issue is requestedverifiedVerification succeeded
Milestone
September 2021

Description

@d3r3kk
Derek Keeler (d3r3kk)
opened on Oct 24, 2018

Related to #974, PR #2913

Once the Python Language Server is enabled for our users by default, update package.json to change the default setting for python.linting.pylintEnabled to false.

Don Jayamanne (@DonJayamanne) Brett Cannon (@brettcannon) Dan Taylor (@qubitron)

Activity

  1. ImageDerek Keeler (d3r3kk)
    added
    feature-requestRequest for new features or functionality
    area-linting
    needs PR
    on Oct 24, 2018
  2. ImageDerek Keeler (d3r3kk)
    added this to the 2018, week 42 - October Sprint 2 milestone on Oct 24, 2018

  3. d3r3kk commented on Oct 24, 2018

    @d3r3kk
    Derek Keeler (d3r3kk)
    on Oct 24, 2018
    Author

    Tracked against the current milestone, but this might get pushed out.
    Brett Cannon (@brettcannon) please correct this if necessary!

  4. DonJayamanne commented on Oct 24, 2018

    @DonJayamanne
    Don Jayamanne (DonJayamanne)
    on Oct 24, 2018

    Hows this different from #974?
    Wouldn't your change above, resolve #974?

  5. brettcannon commented on Oct 25, 2018

    @brettcannon
    Brett Cannon (brettcannon)
    on Oct 25, 2018
    Member

    It's different because #974 makes this a conditional thing that only kicks in when you flip on the language server. Once the language server is the default we can actually flip the default here so that when we stop special-casing Pylint the default is what we want it to be.

  6. ImageBrett Cannon (brettcannon)
    removed this from the 2018, week 42 - October Sprint 2 milestone on Oct 29, 2018
  7. ImageLuciana Abud (luabud)
    added
    importantIssue identified as high-priority
    on Feb 19, 2021
  8. ImageLuciana Abud (luabud)
    added
    planned 📅
    on Apr 27, 2021
  9. ImageBrett Cannon (brettcannon)
    added this to the September 2021 milestone on Sep 1, 2021
  10. ImageBrett Cannon (brettcannon)
    removed
    planned 📅
    on Sep 1, 2021
  11. ImageKim-Adeline Miguel (kimadeline)
    self-assigned this
    on Sep 15, 2021
  12. ImageKim-Adeline Miguel (kimadeline)
    added a commit that references this issue on Sep 15, 2021

    Set pylintEnabled default to false, closes microsoft#3007

    1b5209a
  13. ImageKim-Adeline Miguel (kimadeline)
    closed this as completedin e8b109con Sep 15, 2021
  14. ImageKarthik Nadig (karthiknadig)
    added
    verification-neededVerification of issue is requested
    on Sep 27, 2021

  15. kimadeline commented on Sep 27, 2021

    @kimadeline
    Kim-Adeline Miguel (kimadeline)
    on Sep 27, 2021

    Verification steps

    1. Enable the Python extension
    2. Verify that the default value for the python.linting.pylintEnabled setting is false
  16. ImageRich Chiodo (rchiodo)
    self-assigned this
    on Sep 28, 2021
  17. ImageRich Chiodo (rchiodo)
    added
    verifiedVerification succeeded
    on Sep 28, 2021

  18. rchiodo commented on Sep 28, 2021

    @rchiodo
    Rich Chiodo (rchiodo)
    on Sep 28, 2021

    /verified

  19. Imagegithub-actions
    locked as resolved and limited conversation to collaborators on Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-lintingfeature-requestRequest for new features or functionalityimportantIssue identified as high-priorityverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions