Repository navigation
fix(refresher): avoid gesture setup after disconnect - #31316
Merged
Merged
Conversation
|
@ptmkenny is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
ShaneK
changed the title
ShaneK
requested changes
Aug 3, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Thank you so much for your issue and pull request! I just had a few quest change requests and the rest looks good to me
Co-authored-by: Shane <shane@shanessite.net>
Co-authored-by: Shane <shane@shanessite.net>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
approved these changes
Aug 3, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Awesome work! Looks good to me, thank you!
Member
|
Thanks for your contribution! This should be deployed this Wednesday with our usual patch release |
HappyKnuckles
pushed a commit
to HappyKnuckles/ionic-framework
that referenced
this pull request
Oct 3, 2026
Issue number: resolves ionic-team#31315 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When an `ion-refresher`'s host page is unmounted while the native refresher is still being set up, Ionic throws an uncaught `TypeError` from the gesture utility: ``` TypeError: Cannot read properties of undefined (reading '__zone_symbol__addEventListener') at addEventListener (core/src/utils/gesture/listener.ts:21) at Object.enable (core/src/utils/gesture/index.ts) at Refresher.disabledChanged (core/src/components/refresher/refresher.tsx:125) at Refresher.setupMDNativeRefresher (core/src/components/refresher/refresher.tsx:372) ``` `setupMDNativeRefresher()` and `setupiOSNativeRefresher()` both do: ```ts this.gesture = (await import('../../utils/gesture')).createGesture({ el: this.scrollEl!, ... }); ``` The dynamic import yields to the event loop. If the refresher is disconnected while it resolves, `disconnectedCallback()` (line 547-549) has already run `this.scrollEl = undefined`, so `createGesture` receives `el: undefined`, and the subsequent `disabledChanged()` → `gesture.enable(true)` calls `addEventListener(undefined, ...)`, which throws. Because this happens inside an async method that nothing awaits, it surfaces as an **unhandled promise rejection** — it cannot be caught by a framework error boundary; this crashes my app in playwright sometimes when components are mounted very quickly. The `!` non-null assertions on `this.scrollEl` are what hide this from TypeScript. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> If the refresher is disconnected while the gesture module is being imported, setup aborts quietly. No gesture is created, and no error is thrown. ## Does this introduce a breaking change? - [ ] Yes - [ X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: Shane <shane@shanessite.net>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31315
What is the current behavior?
When an
ion-refresher's host page is unmounted while the native refresher is still being set up, Ionic throws an uncaughtTypeErrorfrom the gesture utility:setupMDNativeRefresher()andsetupiOSNativeRefresher()both do:The dynamic import yields to the event loop. If the refresher is disconnected while it resolves,
disconnectedCallback()(line 547-549) has already runthis.scrollEl = undefined, socreateGesturereceivesel: undefined, and the subsequentdisabledChanged()→gesture.enable(true)callsaddEventListener(undefined, ...), which throws.Because this happens inside an async method that nothing awaits, it surfaces as an unhandled promise rejection — it cannot be caught by a framework error boundary; this crashes my app in playwright sometimes when components are mounted very quickly.
The
!non-null assertions onthis.scrollElare what hide this from TypeScript.What is the new behavior?
If the refresher is disconnected while the gesture module is being imported, setup aborts quietly. No gesture is created, and no error is thrown.
Does this introduce a breaking change?
Other information