Skip to content

Linking PR to issue(s) from the PR Overview - #5825

Closed
Mohamed Amara (mohamedamara1) wants to merge 6 commits into
microsoft:mainfrom
mohamedamara1:feature/5824
Closed

Mohamed Amara (mohamedamara1) wants to merge 6 commits into
microsoft:mainfrom
mohamedamara1:feature/5824

Conversation

@mohamedamara1

Copy link
Copy Markdown
Contributor

Fixes #5824

@mohamedamara1
Mohamed Amara (mohamedamara1) marked this pull request as draft March 10, 2024 15:39
@mohamedamara1

Copy link
Copy Markdown
Contributor Author

Mohamed Amara (@mohamedamara1) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@alexr00

Copy link
Copy Markdown
Member

Mohamed Amara (@mohamedamara1), do you want to pick this PR back up? I never reviewed it because it was always marked as a draft. Let me know if you want feedback on your change!

@mohamedamara1

Copy link
Copy Markdown
Contributor Author

Alex Ross (@alexr00) I still want to work on it, been a bit busy. I will mark it as ready for review when I'm done with implementing it.

@mohamedamara1

Copy link
Copy Markdown
Contributor Author

I tried to pick this up again by syncing with the main branch. I resolved the conflicts and then ran into a lot of build errors so I think I'm gonna iterate on it again on another fresh PR and understand better the changes that have been made to the codebase.

@mohamedamara1

Copy link
Copy Markdown
Contributor Author

Sorry for the PR duplication but II closed this in favor of #6835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display linked issue(s) from the PR Overview

2 participants