Repository navigation
[tree] Run multi-source I/O rules regardless of target order - #23762
Open
SamdaniSayam wants to merge 1 commit into
Open
SamdaniSayam wants to merge 1 commit into
SamdaniSayam wants to merge 1 commit into
Conversation
TStreamerInfo::InsertArtificialElements attaches the rule read function only to the artificial element of the first target and inserts all artificial elements of the rule after the element of the last source. Previously, TBranchElement::InitInfo stopped collecting artificial elements for a sub-branch as soon as the artificial element name differed from the sub-branch name, while GatherArtificialElements skipped any artificial element whose target name matched an existing sub-branch. When the first target was not the last source, neither the last-source sub-branch nor the parent branch claimed the artificial element carrying the read function. Allow sub-branches in InitInfo to collect immediately following TStreamerArtificial elements regardless of target name, and update GatherArtificialElements so the parent branch only collects artificial elements not already claimed by a preceding sub-branch. Fixes root-project#23686.
SamdaniSayam
requested review from
bellenot,
jblomer and
pcanal
as code owners
October 19, 2026 15:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TStreamerInfo::InsertArtificialElements attaches the rule read function only to the artificial element of the first target and inserts all artificial elements of the rule after the element of the last source.
Previously, TBranchElement::InitInfo stopped collecting artificial elements for a sub-branch as soon as the artificial element name differed from the sub-branch name, while GatherArtificialElements skipped any artificial element whose target name matched an existing sub-branch. When the first target was not the last source, neither the last-source sub-branch nor the parent branch claimed the artificial element carrying the read function.
Allow sub-branches in InitInfo to collect immediately following TStreamerArtificial elements regardless of target name, and update GatherArtificialElements so the parent branch only collects artificial elements not already claimed by a preceding sub-branch.
Fixes #23686.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #